Fix generating Pharmacode 2 with invalid input #118

Author: casperbakker

src/Types/TypePharmacodeTwoCode.php

@@ -9,13 +9,18 @@
 
 use Picqer\Barcode\Barcode;
 use Picqer\Barcode\BarcodeBar;
+use Picqer\Barcode\Exceptions\InvalidLengthException;
 
 class TypePharmacodeTwoCode implements TypeInterface
 {
     public function getBarcodeData(string $code): Barcode
     {
         $code = intval($code);
 
+        if ($code < 1) {
+            throw new InvalidLengthException('Pharmacode 2 needs a number of 1 or larger');
+        }
+
         $seq = '';
 
         do {

tests/PharmacodeTest.php

@@ -0,0 +1,15 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+
+class PharmacodeTest extends TestCase
+{
+    public function test_validation_triggerd_when_generating_zero_code()
+    {
+        $pharmacode = new Picqer\Barcode\Types\TypePharmacodeTwoCode();
+
+        $this->expectException(Picqer\Barcode\Exceptions\InvalidLengthException::class);
+
+        $pharmacode->getBarcodeData('0');
+    }
+}