Return condition directly

Instead of using:

    if condition:
        return True
    else:
        return False

Use:

    return bool(condition)

Author: WhyNotHugo

khal/icalendar.py

@@ -469,10 +469,7 @@ def sanitize_rrule(vevent):
 
 def invalid_timezone(prop):
     """check if an icalendar property has a timezone attached we don't understand"""
-    if hasattr(prop.dt, 'tzinfo') and prop.dt.tzinfo is None and 'TZID' in prop.params:
-        return True
-    else:
-        return False
+    return bool(hasattr(prop.dt, 'tzinfo') and prop.dt.tzinfo is None and 'TZID' in prop.params)
 
 
 def _get_all_properties(vevent, prop):

khal/ui/calendarwidget.py

@@ -110,10 +110,7 @@ def reset_styles(self, focus: bool=False) -> None:
 
     @property
     def marked(self) -> bool:
-        if 'mark' in [self.halves[0].attr_map[None], self.halves[1].attr_map[None]]:
-            return True
-        else:
-            return False
+        return 'mark' in [self.halves[0].attr_map[None], self.halves[1].attr_map[None]]
 
     @classmethod
     def selectable(cls) -> bool:

khal/utils.py

@@ -151,10 +151,7 @@ def to_naive_utc(dtime: dt.datetime) -> dt.datetime:
 
 def is_aware(dtime: dt.datetime) -> bool:
     """test if a datetime instance is timezone aware"""
-    if dtime.tzinfo is not None and dtime.tzinfo.utcoffset(dtime) is not None:
-        return True
-    else:
-        return False
+    return bool(dtime.tzinfo is not None and dtime.tzinfo.utcoffset(dtime) is not None)
 
 
 def relative_timedelta_str(day: dt.date) -> str:

tests/conftest.py

@@ -48,7 +48,7 @@ def coll_vdirs(tmpdir) -> CollVdirType:
     for name in example_cals:
         path = str(tmpdir) + '/' + name
         os.makedirs(path, mode=0o770)
-        readonly = True if name == 'a_calendar' else False
+        readonly = name == 'a_calendar'
         calendars[name] = CalendarConfiguration(
             name=name,
             path=path,
@@ -70,7 +70,7 @@ def coll_vdirs_birthday(tmpdir):
     for name in example_cals:
         path = str(tmpdir) + '/' + name
         os.makedirs(path, mode=0o770)
-        readonly = True if name == 'a_calendar' else False
+        readonly = name == 'a_calendar'
         calendars[name] = {'name': name, 'path': path, 'color': 'dark blue',
                            'readonly': readonly, 'unicode_symbols': True, 'ctype': 'birthdays',
                            'addresses': '[email protected]'}