-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: remove fullRange check from skyline pruning (#63828) #64057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.1
Are you sure you want to change the base?
planner: remove fullRange check from skyline pruning (#63828) #64057
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@terry1purcell This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/unhold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #64057 +/- ##
================================================
Coverage ? 71.2450%
================================================
Files ? 1470
Lines ? 424556
Branches ? 0
================================================
Hits ? 302475
Misses ? 101529
Partials ? 20552
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, terry1purcell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #63828
What problem does this PR solve?
Issue Number: ref #63235
Problem Summary:
What changed and how does it work?
FullRange check was found to be expensive in some scenarios. This PR will only call this after other criteria has been validated.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.