From 6e4fffb398b0d47562c39bacc16d55851b34dab7 Mon Sep 17 00:00:00 2001 From: Artur Pata Date: Mon, 14 Jul 2025 11:51:34 +0300 Subject: [PATCH] Remove now superfluous props.path for '404' and 'WP Form Completions' --- assets/src/js/integrations/form-submit.js | 2 +- assets/src/js/integrations/form-submit.min.js | 2 +- src/Actions.php | 15 +-------------- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/assets/src/js/integrations/form-submit.js b/assets/src/js/integrations/form-submit.js index 3eb44a8..dd5cac8 100644 --- a/assets/src/js/integrations/form-submit.js +++ b/assets/src/js/integrations/form-submit.js @@ -33,7 +33,7 @@ document.addEventListener('DOMContentLoaded', () => { * Send a custom event to Plausible. */ trackSubmission: function () { - plausible(plausible_analytics_i18n.form_completions, {'props': {'path': document.location.pathname}}); + plausible(plausible_analytics_i18n.form_completions); } }; diff --git a/assets/src/js/integrations/form-submit.min.js b/assets/src/js/integrations/form-submit.min.js index 96ee53f..4738340 100644 --- a/assets/src/js/integrations/form-submit.min.js +++ b/assets/src/js/integrations/form-submit.min.js @@ -1 +1 @@ -document.addEventListener("DOMContentLoaded",()=>{let plausible_track_form_submit={forms:document.querySelectorAll("form"),init:function(){this.bindEvents()},bindEvents:function(){let self=this;this.forms.forEach(form=>{form.addEventListener("submit",e=>{if(e.target.checkValidity()){self.trackSubmission()}})})},trackSubmission:function(){plausible(plausible_analytics_i18n.form_completions,{props:{path:document.location.pathname}})}};plausible_track_form_submit.init()}); \ No newline at end of file +document.addEventListener("DOMContentLoaded",()=>{let plausible_track_form_submit={forms:document.querySelectorAll("form"),init:function(){this.bindEvents()},bindEvents:function(){let self=this;this.forms.forEach(form=>{form.addEventListener("submit",e=>{if(e.target.checkValidity()){self.trackSubmission()}})})},trackSubmission:function(){plausible(plausible_analytics_i18n.form_completions)}};plausible_track_form_submit.init()}); \ No newline at end of file diff --git a/src/Actions.php b/src/Actions.php index 257f1ff..8fe0935 100644 --- a/src/Actions.php +++ b/src/Actions.php @@ -71,22 +71,9 @@ public function maybe_register_assets() { // Track 404 pages (if enabled) if ( Helpers::is_enhanced_measurement_enabled( '404' ) && is_404() ) { - $data = wp_json_encode( - [ - 'props' => [ - 'path' => 'document.location.pathname', - ], - ] - ); - - /** - * document.location.pathname is a variable. @see wp_json_encode() doesn't allow passing variable, only strings. This fixes that. - */ - $data = str_replace( '"document.location.pathname"', 'document.location.pathname', $data ); - wp_add_inline_script( 'plausible-analytics', - "document.addEventListener('DOMContentLoaded', function () { plausible( '404', $data ); });" + "document.addEventListener('DOMContentLoaded', function () { plausible( '404' ) });" ); }