[ModernTaxonomyPicker] getLabelsForCurrentLanguage returns empty array

[IRRDC]

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.21.0]

Observed Behavior

I noticed a crash of the DynamicForm control on my mixed language test site and traced it to the getLabelsForCurrentLanguage method of the ModernTaxonomyPicker.tsx.
After uploading some pictures to my test doc lib SharePoint added a new column called Image Tags of type TaxonomyFieldTypeMulti and assigned terms like "Screenshot". According to the data returned, the terms are labeled in German de-DE only and the only labels returned are marked as default, but the default language for the site is en-US. In the current code this will lead to no labels being found and onRenderItem to crash when accessing labels[0].name:

I suggest to add more fallbacks to prevent this behavior, e.g.
let labels = item.labels.filter((name) => name.languageTag === currentLanguageTag && name.isDefault);
if (labels.length === 0) {
labels = item.labels.filter((name) => name.languageTag === currentTermStoreInfo.defaultLanguageTag && name.isDefault);
}
if (labels.length === 0) {
labels = item.labels.filter((name) => name.isDefault);
}
if (labels.length === 0) {
labels.push(item.labels[0]);
}
return labels;

[diabhoil]

Hey @IRRDC, I can not realy reproduce this. Even if I am able to not matching the first condition "name.languageTag === currentLanguageTag && name.isDefault". I always have the 2nd condition (name.languageTag === currentTermStoreInfo.defaultLanguageTag && name.isDefault) hit, because I must have a label in the default language of the term store, which then is always "isDefault = true".

I tried to remove the translation for a term in the term store but that does not work. I changed the default language of the term store from en-US to de-DE, but now every term does have a de-DE translation copied from en-US (when not present before). So in the picker I still have the 2nd condition met.

[IRRDC]

In my case the site got created as German but my user account has preferences set to display SharePoint Online in English.

[diabhoil]

@IRRDC Ok I set the default language of the termStore to German, used a Term with german label only, created a german SiteCollection and used a user account with English language. Then I am hitting the 2nd condition.

For me "name.isDefault" is always set to true and I always have a label in the term store default language. So "name.languageTag === currentTermStoreInfo.defaultLanguageTag && name.isDefault" is returning always a label. This condition completly ignores my personal UI language.