Skip to content

Conversation

@willieyz
Copy link
Contributor

@willieyz willieyz commented Nov 4, 2025

  • During PR Add Runtime dispatch based on custom CPU capabilities function #607, we found some differences in the functions parameter between mata.h and api.h, and we have aligned them in this PR.
  • This PR fix two problem:
    • Correcting the parameter type for mld_intt_native, aligned with meta.h
    • Making array dimensions explicit in the polyvecl pointwise accumulation functions, aligned with meta.h

@willieyz willieyz marked this pull request as ready for review November 4, 2025 12:29
@willieyz willieyz requested a review from a team as a code owner November 4, 2025 12:29
@mkannwischer mkannwischer changed the title Fix function type and array sizes Align native api.h with meta.h Nov 5, 2025
This commit fixes two issues:
  - correcting the parameter type for `mld_intt_native`
  - making array dimensions concrete in the polyvecl pointwise
    accumulation functions rather than using MLDSA_L

Signed-off-by: willieyz <[email protected]>
@mkannwischer mkannwischer merged commit 8306454 into main Nov 5, 2025
247 checks passed
@mkannwischer mkannwischer deleted the fix-type-array-size branch November 5, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants