fix: Check existence earlier, than other characteristics like focused

BREAKING CHANGE: If more "is*" instructions are used, the order has been changed to prevent unnecessary blocks. Earlier, visibility was checked before other features, which could confuse the error reporting. The new order of evaluation of "is*" instruction reflects their importance. The instructions can be put to a single block, evaluated in the "natural" order and fail with the most important condition:

 * isExisting
 * isVisible
 * isVisibleWithinViewport
 * isEnabled
 * isSelected
 * isFocused
 * isNotExisting
 * isNotVisible
 * isNotVisibleWithinViewport
 * isNotEnabled
 * isNotFocused

This is very unlikely to break anything in real-world commands, but still, better to be sure.

Author: prantlf

INSTRUCTIONS.md

@@ -28,18 +28,18 @@ One of the instructions has to be present in every command. These properties are
 - [hasText](#hastext)
 - [hasInnerHtml](#hasinnerhtml)
 - [hasOuterHtml](#hasouterhtml)
-- [isEnabled](#isenabled)
 - [isExisting](#isexisting)
-- [isFocused](#isfocused)
-- [isSelected](#isselected)
 - [isVisible](#isvisible)
 - [isVisibleWithinViewport](#isvisiblewithinviewport)
-- [isNotEnabled](#isnotenabled)
+- [isEnabled](#isenabled)
+- [isSelected](#isselected)
+- [isFocused](#isfocused)
 - [isNotExisting](#isnotexisting)
-- [isNotFocused](#isnotfocused)
-- [isNotSelected](#isnotselected)
 - [isNotVisible](#isnotvisible)
 - [isNotVisibleWithinViewport](#isnotvisiblewithinviewport)
+- [isNotEnabled](#isnotenabled)
+- [isNotSelected](#isnotselected)
+- [isNotFocused](#isnotfocused)
 - [break](#break)
 - [abort](#abort)
 - [file](#file)

README.md

@@ -303,18 +303,18 @@ One of the [instructions] has to be present in every command, otherwise its exec
 * [hasText](INSTRUCTIONS.md#hastext)
 * [hasInnerHtml](INSTRUCTIONS.md#hasinnerhtml)
 * [hasOuterHtml](INSTRUCTIONS.md#hasouterhtml)
-* [isEnabled](INSTRUCTIONS.md#isenabled)
 * [isExisting](INSTRUCTIONS.md#isexisting)
-* [isFocused](INSTRUCTIONS.md#isfocused)
-* [isSelected](INSTRUCTIONS.md#isselected)
 * [isVisible](INSTRUCTIONS.md#isvisible)
 * [isVisibleWithinViewport](INSTRUCTIONS.md#isvisiblewithinviewport)
-* [isNotEnabled](INSTRUCTIONS.md#isnotenabled)
+* [isEnabled](INSTRUCTIONS.md#isenabled)
+* [isSelected](INSTRUCTIONS.md#isselected)
+* [isFocused](INSTRUCTIONS.md#isfocused)
 * [isNotExisting](INSTRUCTIONS.md#isnotexisting)
-* [isNotFocused](INSTRUCTIONS.md#isnotfocused)
-* [isNotSelected](INSTRUCTIONS.md#isnotselected)
 * [isNotVisible](INSTRUCTIONS.md#isnotvisible)
 * [isNotVisibleWithinViewport](INSTRUCTIONS.md#isnotvisiblewithinviewport)
+* [isNotEnabled](INSTRUCTIONS.md#isnotenabled)
+* [isNotSelected](INSTRUCTIONS.md#isnotselected)
+* [isNotFocused](INSTRUCTIONS.md#isnotfocused)
 * [break](INSTRUCTIONS.md#break)
 * [abort](INSTRUCTIONS.md#abort)
 * [file](INSTRUCTIONS.md#file)

tasks/html-dom-snapshot.js

@@ -12,10 +12,10 @@ const instructionKeys = [
   'addValue', 'selectOptionByIndex', 'selectOptionByValue', 'moveCursor',
   'click', 'clickIfVisible', 'keys', 'elementSendKeys', 'wait', 'hasAttribute',
   'hasClass', 'hasValue', 'hasText', 'hasInnerHtml', 'hasOuterHtml',
-  'isEnabled', 'isExisting', 'isFocused', 'isSelected', 'isVisible',
-  'isVisibleWithinViewport', 'isNotEnabled', 'isNotExisting',
-  'isNotFocused', 'isNotSelected', 'isNotVisible',
-  'isNotVisibleWithinViewport', 'break', 'abort'
+  'isExisting', 'isVisible', 'isVisibleWithinViewport', 'isEnabled',
+  'isSelected', 'isFocused', 'isNotExisting', 'isNotVisible',
+  'isNotVisibleWithinViewport', 'isNotEnabled', 'isNotFocused',
+  'isNotSelected', 'break', 'abort'
 ]
 const instructions = instructionKeys.map(instruction =>
   require('./instructions/' + instruction))