Skip to content

Commit e5b16cc

Browse files
committed
Fix select options overlaying navigation on mobile
1 parent b83370a commit e5b16cc

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

features/issues/components/filters/filters.tsx

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import React, { useState, useContext } from "react";
1+
import React, { useState } from "react";
22
import { useWindowSize } from "react-use";
33
import { useDebouncedCallback } from "use-debounce";
44
import { capitalize } from "lodash";
5-
import { Select, Option, Input, NavigationContext } from "@features/ui";
5+
import { Select, Option, Input } from "@features/ui";
66
import { IssueFilters, IssueLevel, IssueStatus } from "@api/issues.types";
77
import { useFilters } from "../../hooks/use-filters";
88
import * as S from "./filters.styled";
@@ -32,7 +32,6 @@ export function Filters() {
3232

3333
const { width } = useWindowSize();
3434
const isMobileScreen = width <= 1023;
35-
const { isMobileMenuOpen } = useContext(NavigationContext);
3635

3736
const handleChange = (project: string) => {
3837
setInputValue(project);
@@ -62,11 +61,6 @@ export function Filters() {
6261
placeholder="Status"
6362
defaultValue={getStatusDefaultValue(filters)}
6463
width={isMobileScreen ? "97%" : "8rem"}
65-
style={{
66-
...(isMobileMenuOpen && {
67-
opacity: 0,
68-
}),
69-
}}
7064
>
7165
<Option value={undefined} handleCallback={handleStatus}>
7266
--None--
@@ -83,11 +77,6 @@ export function Filters() {
8377
placeholder="Level"
8478
defaultValue={getLevelDefaultValue(filters)}
8579
width={isMobileScreen ? "97%" : "8rem"}
86-
style={{
87-
...(isMobileMenuOpen && {
88-
opacity: 0,
89-
}),
90-
}}
9180
>
9281
<Option value={undefined} handleCallback={handleLevel}>
9382
--None--
@@ -109,12 +98,6 @@ export function Filters() {
10998
label="project name"
11099
placeholder="Project Name"
111100
iconSrc="/icons/search-icon.svg"
112-
style={{
113-
...(isMobileScreen && { width: "94%", marginRight: "3rem" }),
114-
...(isMobileMenuOpen && {
115-
opacity: 0,
116-
}),
117-
}}
118101
/>
119102
</S.Container>
120103
);

features/ui/sidebar-navigation/sidebar-navigation.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ const Container = styled.div<{ isCollapsed: boolean }>`
4949
const FixedContainer = styled.div`
5050
${containerStyles}
5151
position: fixed;
52+
z-index: 1;
5253
`;
5354

5455
const Header = styled.header`

0 commit comments

Comments
 (0)