Skip to content

Commit 5cd5deb

Browse files
committed
Un-pend a test for catalog URLs with slashes in the document ID
Ref #911 Solr documents with a slash in the ID seem to route correctly without additional changes now. I tested by adding a document to the index and then checking its catalog URL; Rails's link_to seems to automatically generate a link with an encoded slash. Unfortunately this does not apply to a period, so full URLs won't work.
1 parent 3e3e63c commit 5cd5deb

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

spec/routing/catalog_routing_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
end
4242

4343
it "routes url-like ids" do
44-
skip "This works if you configure your routing to have very liberal constraints on :id.. not sure how to go about testing it though"
44+
# skip "This works if you configure your routing to have very liberal constraints on :id.. not sure how to go about testing it though"
4545
expect(get: solr_document_path(SolrDocument.new(id: 'http://example.com'))).to route_to(controller: 'catalog', action: 'show', id: 'http://example.com')
4646
end
4747

@@ -54,7 +54,6 @@
5454
end
5555

5656
it "routes ids with a literal '/" do
57-
skip "This works if you configure your routing to have very liberal constraints on :id.. not sure how to go about testing it though"
5857
expect(get: solr_document_path(SolrDocument.new(id: 'and/or'))).to route_to(controller: 'catalog', action: 'show', id: 'and/or')
5958
end
6059
end

0 commit comments

Comments
 (0)