Skip to content

Commit ebde091

Browse files
committed
refactor: add jdk8 compile check
Signed-off-by: moxiaoying <[email protected]>
1 parent 34f0294 commit ebde091

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
# Copyright 2024 OpenFacade Authors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
name: java8 compile
16+
on:
17+
push:
18+
branches:
19+
- main
20+
pull_request:
21+
branches:
22+
- main
23+
24+
jobs:
25+
java8_compile:
26+
runs-on: ubuntu-latest
27+
steps:
28+
- uses: actions/checkout@v4
29+
- name: Set up Maven Central Repository
30+
uses: actions/setup-java@v4
31+
with:
32+
java-version: '8'
33+
distribution: 'temurin'
34+
- name: compile
35+
run: mvn -B clean package -Dmaven.test.skip=true

pulsar-admin/src/main/java/io/github/protocol/pulsar/admin/jdk/InnerHttpClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class InnerHttpClient {
2929

3030
public InnerHttpClient(Configuration conf) {
3131
HttpClientConfig.Builder clientConfigBuilder = new HttpClientConfig.Builder();
32-
clientConfigBuilder.engine(HttpClientEngine.JAVA);
32+
clientConfigBuilder.engine(HttpClientEngine.Java);
3333
if (conf.tlsEnabled) {
3434
TlsConfig.Builder tlsConfigBuilder = new TlsConfig.Builder();
3535
io.github.protocol.pulsar.admin.api.TlsConfig tlsConfig = conf.tlsConfig;

0 commit comments

Comments
 (0)