Skip to content
This repository was archived by the owner on Dec 2, 2022. It is now read-only.

Commit 319dc9a

Browse files
committed
Merge pull request #17 from muratayusuke/bugfix/ignore_int_param
Bugfix: Do not ignore Int and Bool parameters when making requests to the web api
2 parents 3efe575 + 64440b5 commit 319dc9a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

SlackKit/Sources/NetworkInterface.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ internal struct NetworkInterface {
3030
internal func request(endpoint: SlackAPIEndpoint, token: String, parameters: [String: AnyObject]?, successClosure: ([String: AnyObject])->Void, errorClosure: (SlackError)->Void) {
3131
var requestString = "\(apiUrl)\(endpoint.rawValue)?token=\(token)"
3232
if let params = parameters {
33-
requestString = requestString + requestStringFromParameters(params)
33+
requestString += requestStringFromParameters(params)
3434
}
3535
let request = NSURLRequest(URL: NSURL(string: requestString)!)
3636
NSURLSession.sharedSession().dataTaskWithRequest(request) {
@@ -119,7 +119,9 @@ internal struct NetworkInterface {
119119
var requestString = ""
120120
for key in parameters.keys {
121121
if let value = parameters[key] as? String, encodedValue = value.stringByAddingPercentEncodingWithAllowedCharacters(NSCharacterSet.URLHostAllowedCharacterSet()) {
122-
requestString = requestString + "&"+key+"="+encodedValue
122+
requestString += "&\(key)=\(encodedValue)"
123+
} else if let value = parameters[key] as? Int {
124+
requestString += "&\(key)=\(value)"
123125
}
124126
}
125127

0 commit comments

Comments
 (0)