fix: go to file functionality #1083
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR fixes an issue that was accidentally introduced in #538 where the
BufEnterautocmd broke the existing go to file functionality viagf. We should only setup this autocmd if theuse_local_fsoption is set totrue, as this autocmd was intended to be used only if that option was enabled.Describe how you did it
Did a bit manual git bisecting to find the commit that introduced the problem.
Describe how to verify it
Open up a review for a PR and do
gfto go the the file. Ifuse_local_fsis enabled thengfwon't work, but I think that might be the point.Special notes for reviews
Checklist