test error situation

Author: chfw

pyexcel_odsr/converter.py

@@ -39,13 +39,18 @@ def time_value(value):
     """convert to time value accroding the specification"""
     import re
     results = re.match('PT(\d+)H(\d+)M(\d+)S', value)
-    hour = int(results.group(1))
-    minute = int(results.group(2))
-    second = int(results.group(3))
-    if hour < 24:
-        ret = datetime.time(hour, minute, second)
+    if results and len(results.groups()) == 3:
+        hour = int(results.group(1))
+        minute = int(results.group(2))
+        second = int(results.group(3))
+        if hour < 24:
+            ret = datetime.time(hour, minute, second)
+        else:
+            ret = datetime.timedelta(hours=hour,
+                                     minutes=minute,
+                                     seconds=second)
     else:
-        ret = datetime.timedelta(hours=hour, minutes=minute, seconds=second)
+        ret = None
     return ret
 
 

tests/test_bug_fixes.py

@@ -68,3 +68,9 @@ def test_issue_1():
     data = get_data(os.path.join("tests", "fixtures", test_file),
                     skip_empty_rows=True, library='pyexcel-odsr')
     eq_(data['Sheet1'][0][0].days, 12)
+
+
+def test_issue_1_error():
+    from pyexcel_odsr.converter import time_value
+    result = time_value('PT1111')
+    eq_(result, None)