fix #2: read all texts inside the same child

Author: chfw

pyexcel_odsr/messyods.py

@@ -190,19 +190,22 @@ def _read_cell(element):
 
 
 def _read_text_cell(element):
-    children = element.getchildren()
-    text_content = []
-    for child in children:
-        if child.text:
-            text_content.append(child.text)
-        else:
-            text_content.append('')
+    text_content = _recursively_read_text_cell(element)
     if len(text_content) > 0:
         cell_value = '\n'.join(text_content)
     else:
         cell_value = ''
     return (cell_value, 'string')
 
 
+def _recursively_read_text_cell(element):
+    children = element.getchildren()
+    texts = []
+    for child in children:
+        text = "".join([x for x in child.itertext()])
+        texts.append(text)
+    return texts
+
+
 def _tag(namespace, tag):
     return '{%s}%s' % (namespace, tag)

tests/test_bug_fixes.py

@@ -74,3 +74,10 @@ def test_issue_1_error():
     from pyexcel_odsr.converter import time_value
     result = time_value('PT1111')
     eq_(result, None)
+
+
+def test_issue_19():
+    test_file = "pyexcel_81_ods_19.ods"
+    data = get_data(os.path.join("tests", "fixtures", test_file),
+                    skip_empty_rows=True, library='pyexcel-odsr')
+    eq_(data['product.template'][1][1], 'PRODUCT NAME PMP')