Add --no-build-isolation to tests

Most tests use setup.py-based test packages, and we
want to avoid network access for building them.

Author: sbidoul

tests/functional/test_check.py

@@ -34,7 +34,9 @@ def test_basic_check_missing_dependency(script: PipTestEnvironment) -> None:
         install_requires=["missing==0.1"],
     )
     # Let's install pkga without its dependency
-    res = script.pip("install", "--no-index", pkga_path, "--no-deps")
+    res = script.pip(
+        "install", "--no-build-isolation", "--no-index", pkga_path, "--no-deps"
+    )
     assert "Successfully installed pkga-1.0" in res.stdout, str(res)
 
     result = script.pip("check", expect_error=True)
@@ -53,7 +55,9 @@ def test_basic_check_broken_dependency(script: PipTestEnvironment) -> None:
         install_requires=["broken>=1.0"],
     )
     # Let's install pkga without its dependency
-    res = script.pip("install", "--no-index", pkga_path, "--no-deps")
+    res = script.pip(
+        "install", "--no-build-isolation", "--no-index", pkga_path, "--no-deps"
+    )
     assert "Successfully installed pkga-1.0" in res.stdout, str(res)
 
     # Setup broken==0.1
@@ -65,6 +69,7 @@ def test_basic_check_broken_dependency(script: PipTestEnvironment) -> None:
     # Let's install broken==0.1
     res = script.pip(
         "install",
+        "--no-build-isolation",
         "--no-index",
         broken_path,
         "--no-warn-conflicts",
@@ -88,7 +93,9 @@ def test_basic_check_broken_dependency_and_missing_dependency(
         install_requires=["broken>=1.0"],
     )
     # Let's install pkga without its dependency
-    res = script.pip("install", "--no-index", pkga_path, "--no-deps")
+    res = script.pip(
+        "install", "--no-build-isolation", "--no-index", pkga_path, "--no-deps"
+    )
     assert "Successfully installed pkga-1.0" in res.stdout, str(res)
 
     # Setup broken==0.1
@@ -99,7 +106,9 @@ def test_basic_check_broken_dependency_and_missing_dependency(
         install_requires=["missing"],
     )
     # Let's install broken==0.1
-    res = script.pip("install", "--no-index", broken_path, "--no-deps")
+    res = script.pip(
+        "install", "--no-build-isolation", "--no-index", broken_path, "--no-deps"
+    )
     assert "Successfully installed broken-0.1" in res.stdout, str(res)
 
     result = script.pip("check", expect_error=True)
@@ -122,7 +131,9 @@ def test_check_complicated_name_missing(script: PipTestEnvironment) -> None:
     )
 
     # Without dependency
-    result = script.pip("install", "--no-index", package_a_path, "--no-deps")
+    result = script.pip(
+        "install", "--no-build-isolation", "--no-index", package_a_path, "--no-deps"
+    )
     assert (
         "Successfully installed package_A-1.0" in result.stdout
         or "Successfully installed package-A-1.0" in result.stdout
@@ -148,14 +159,17 @@ def test_check_complicated_name_broken(script: PipTestEnvironment) -> None:
     )
 
     # With broken dependency
-    result = script.pip("install", "--no-index", package_a_path, "--no-deps")
+    result = script.pip(
+        "install", "--no-build-isolation", "--no-index", package_a_path, "--no-deps"
+    )
     assert (
         "Successfully installed package_A-1.0" in result.stdout
         or "Successfully installed package-A-1.0" in result.stdout
     ), str(result)
 
     result = script.pip(
         "install",
+        "--no-build-isolation",
         "--no-index",
         dependency_b_path_incompatible,
         "--no-deps",
@@ -184,14 +198,17 @@ def test_check_complicated_name_clean(script: PipTestEnvironment) -> None:
         version="1.0",
     )
 
-    result = script.pip("install", "--no-index", package_a_path, "--no-deps")
+    result = script.pip(
+        "install", "--no-build-isolation", "--no-index", package_a_path, "--no-deps"
+    )
     assert (
         "Successfully installed package_A-1.0" in result.stdout
         or "Successfully installed package-A-1.0" in result.stdout
     ), str(result)
 
     result = script.pip(
         "install",
+        "--no-build-isolation",
         "--no-index",
         dependency_b_path,
         "--no-deps",
@@ -215,7 +232,9 @@ def test_check_considers_conditional_reqs(script: PipTestEnvironment) -> None:
         ],
     )
 
-    result = script.pip("install", "--no-index", package_a_path, "--no-deps")
+    result = script.pip(
+        "install", "--no-build-isolation", "--no-index", package_a_path, "--no-deps"
+    )
     assert (
         "Successfully installed package_A-1.0" in result.stdout
         or "Successfully installed package-A-1.0" in result.stdout
@@ -238,7 +257,9 @@ def test_check_development_versions_are_also_considered(
         install_requires=["depend>=1.0"],
     )
     # Let's install pkga without its dependency
-    res = script.pip("install", "--no-index", pkga_path, "--no-deps")
+    res = script.pip(
+        "install", "--no-build-isolation", "--no-index", pkga_path, "--no-deps"
+    )
     assert "Successfully installed pkga-1.0" in res.stdout, str(res)
 
     # Setup depend==1.1.0.dev0
@@ -250,6 +271,7 @@ def test_check_development_versions_are_also_considered(
     # Let's install depend==1.1.0.dev0
     res = script.pip(
         "install",
+        "--no-build-isolation",
         "--no-index",
         depend_path,
         "--no-warn-conflicts",

tests/functional/test_cli.py

@@ -45,7 +45,9 @@ def test_entrypoints_work(entrypoint: str, script: PipTestEnvironment) -> None:
     )
 
     # expect_temp because pip install will generate fake_pkg.egg-info
-    script.pip("install", "-vvv", str(fake_pkg), expect_temp=True)
+    script.pip(
+        "install", "--no-build-isolation", "-vvv", str(fake_pkg), expect_temp=True
+    )
     result = script.pip("-V")
     result2 = script.run("fake_pip", "-V", allow_stderr_warning=True)
     assert result.stdout == result2.stdout

tests/functional/test_download.py

@@ -54,8 +54,18 @@ def test_download_wheel(script: PipTestEnvironment, data: TestData) -> None:
     """
     Test using "pip download" to download a *.whl archive.
     """
+    # This test needs --no-build-isolation because `meta` depends on `simple`
+    # which is a source distribution for which it needs to prepare metadata
+    # to look for transitive dependencies.
     result = script.pip(
-        "download", "--no-index", "-f", data.packages, "-d", ".", "meta"
+        "download",
+        "--no-build-isolation",
+        "--no-index",
+        "-f",
+        data.packages,
+        "-d",
+        ".",
+        "meta",
     )
     result.did_create(Path("scratch") / "meta-1.0-py2.py3-none-any.whl")
     result.did_not_create(script.site_packages / "piptestpackage")
@@ -122,7 +132,14 @@ def test_download_should_download_wheel_deps(
     dep_filename = "translationstring-1.1.tar.gz"
     wheel_path = "/".join((data.find_links, wheel_filename))
     result = script.pip(
-        "download", wheel_path, "-d", ".", "--find-links", data.find_links, "--no-index"
+        "download",
+        "--no-build-isolation",
+        wheel_path,
+        "-d",
+        ".",
+        "--find-links",
+        data.find_links,
+        "--no-index",
     )
     result.did_create(Path("scratch") / wheel_filename)
     result.did_create(Path("scratch") / dep_filename)
@@ -687,8 +704,7 @@ def make_args(python_version: str) -> list[str]:
     args = make_args("33")
     result = script.pip(*args, expect_error=True)
     expected_err = (
-        "ERROR: Package 'mypackage' requires a different Python: "
-        "3.3.0 not in '==3.2'"
+        "ERROR: Package 'mypackage' requires a different Python: 3.3.0 not in '==3.2'"
     )
     assert expected_err in result.stderr, f"stderr: {result.stderr}"
 
@@ -978,6 +994,7 @@ def test_download_prefer_binary_when_wheel_doesnt_satisfy_req(
 
     result = script.pip(
         "download",
+        "--no-build-isolation",
         "--prefer-binary",
         "--no-index",
         "-f",
@@ -1006,6 +1023,7 @@ def test_prefer_binary_when_wheel_doesnt_satisfy_req_req_file(
 
     result = script.pip(
         "download",
+        "--no-build-isolation",
         "--no-index",
         "-f",
         data.packages,
@@ -1023,6 +1041,7 @@ def test_download_prefer_binary_when_only_tarball_exists(
 ) -> None:
     result = script.pip(
         "download",
+        "--no-build-isolation",
         "--prefer-binary",
         "--no-index",
         "-f",
@@ -1047,6 +1066,7 @@ def test_prefer_binary_when_only_tarball_exists_req_file(
     )
     result = script.pip(
         "download",
+        "--no-build-isolation",
         "--no-index",
         "-f",
         data.packages,
@@ -1078,6 +1098,7 @@ def test_download_file_url(
 
     shared_script.pip(
         "download",
+        "--no-build-isolation",
         "-d",
         str(download_dir),
         "--no-index",
@@ -1102,7 +1123,12 @@ def test_download_file_url_existing_ok_download(
     url = f"{simple_pkg.as_uri()}#sha256={sha256(downloaded_path_bytes).hexdigest()}"
 
     shared_script.pip(
-        "download", "-d", str(download_dir), url, "--disable-pip-version-check"
+        "download",
+        "--no-build-isolation",
+        "-d",
+        str(download_dir),
+        url,
+        "--disable-pip-version-check",
     )
 
     assert downloaded_path_bytes == downloaded_path.read_bytes()
@@ -1123,6 +1149,7 @@ def test_download_file_url_existing_bad_download(
 
     result = shared_script.pip(
         "download",
+        "--no-build-isolation",
         "-d",
         str(download_dir),
         url,
@@ -1159,6 +1186,7 @@ def test_download_http_url_bad_hash(
 
     result = shared_script.pip(
         "download",
+        "--no-build-isolation",
         "-d",
         str(download_dir),
         url,
@@ -1187,7 +1215,13 @@ def test_download_editable(
     requirements_path.write_text("-e " + editable_path + "\n")
     download_dir = tmpdir / "download_dir"
     script.pip(
-        "download", "--no-deps", "-r", str(requirements_path), "-d", str(download_dir)
+        "download",
+        "--no-build-isolation",
+        "--no-deps",
+        "-r",
+        str(requirements_path),
+        "-d",
+        str(download_dir),
     )
     downloads = os.listdir(download_dir)
     assert len(downloads) == 1
@@ -1256,6 +1290,7 @@ def run_for_generated_index(
         """
         pip_args = [
             "download",
+            "--no-build-isolation",
             "-d",
             str(download_dir),
             "-i",
@@ -1287,6 +1322,7 @@ def run_for_generated_index(
         """
         pip_args = [
             "download",
+            "--no-build-isolation",
             "-d",
             str(download_dir),
             "-i",

tests/functional/test_freeze.py

@@ -209,7 +209,7 @@ def test_freeze_editable_not_vcs(script: PipTestEnvironment) -> None:
     # Rename the .git directory so the directory is no longer recognized
     # as a VCS directory.
     os.rename(os.path.join(pkg_path, ".git"), os.path.join(pkg_path, ".bak"))
-    script.pip("install", "-e", pkg_path)
+    script.pip("install", "--no-build-isolation", "-e", pkg_path)
     result = script.pip("freeze")
 
     # We need to apply os.path.normcase() to the path since that is what
@@ -231,7 +231,7 @@ def test_freeze_editable_git_with_no_remote(
     Test an editable Git install with no remote url.
     """
     pkg_path = _create_test_package(script.scratch_path)
-    script.pip("install", "-e", pkg_path)
+    script.pip("install", "--no-build-isolation", "-e", pkg_path)
     result = script.pip("freeze")
 
     if not deprecated_python:
@@ -595,7 +595,7 @@ def test_freeze_nested_vcs(
         os.fspath(src_path),
         expect_stderr=True,
     )
-    script.pip("install", "-e", src_path, expect_stderr=True)
+    script.pip("install", "--no-build-isolation", "-e", src_path, expect_stderr=True)
 
     # Check the freeze output recognizes the inner VCS.
     result = script.pip("freeze", expect_stderr=True)
@@ -993,7 +993,7 @@ def test_freeze_direct_url_archive(
     script: PipTestEnvironment, shared_data: TestData
 ) -> None:
     req = "simple @ " + shared_data.packages.joinpath("simple-2.0.tar.gz").as_uri()
-    script.pip("install", req)
+    script.pip("install", "--no-build-isolation", req)
     result = script.pip("freeze")
     assert req in result.stdout
 
@@ -1037,7 +1037,7 @@ def test_freeze_pep610_editable(script: PipTestEnvironment) -> None:
     is correctly frozeon as editable.
     """
     pkg_path = _create_test_package(script.scratch_path, name="testpkg")
-    result = script.pip("install", pkg_path)
+    result = script.pip("install", "--no-build-isolation", pkg_path)
     direct_url_path = result.get_created_direct_url_path("testpkg")
     assert direct_url_path
     # patch direct_url.json to simulate an editable install