Skip to content

Commit c11fa83

Browse files
committed
Exclude docs
1 parent 53d0705 commit c11fa83

File tree

15 files changed

+47
-51
lines changed

15 files changed

+47
-51
lines changed

.github/pr-labeler-config.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,55 @@
11
# Add 'docker' to any changes within 'docker' folder or any subfolders
22
docker:
33
- changed-files:
4-
- any-glob-to-any-file: docker/**
4+
- any-glob-to-any-file: docker/**
55

66
# Add 'docs' to any changes within 'docs' folder
77
docs:
88
- changed-files:
9-
- any-glob-to-any-file: docs/**
9+
- any-glob-to-any-file: docs/**
1010

1111
# Add 'ci' to any changes in '.github' folder
1212
ci:
1313
- changed-files:
14-
- any-glob-to-any-file: .github/**
14+
- any-glob-to-any-file: .github/**
1515

1616
# Add 'examples' to any changes within 'examples' folder
1717
examples:
1818
- changed-files:
19-
- any-glob-to-any-file: examples/**
19+
- any-glob-to-any-file: examples/**
2020

2121
# Add 'base' to any changes within 'base' folder
2222
"module: base":
2323
- changed-files:
24-
- any-glob-to-any-file: ignite/base/**/*
24+
- any-glob-to-any-file: ignite/base/**/*
2525

2626
# Add 'contrib' to any changes within 'contrib' folder
2727
"module: contrib":
2828
- changed-files:
29-
- any-glob-to-any-file: ignite/contrib/**/*
29+
- any-glob-to-any-file: ignite/contrib/**/*
3030

3131
# Add 'distributed' to any changes within 'distributed' folder
3232
"module: distributed":
3333
- changed-files:
34-
- any-glob-to-any-file: ignite/distributed/**/*
34+
- any-glob-to-any-file: ignite/distributed/**/*
3535

3636
# Add 'engine' to any changes within 'engine' folder
3737
"module: engine":
3838
- changed-files:
39-
- any-glob-to-any-file: ignite/engine/**/*
39+
- any-glob-to-any-file: ignite/engine/**/*
4040

4141
# Add 'handlers' to any changes within 'handlers' folder
4242
"module: handlers":
4343
- changed-files:
44-
- any-glob-to-any-file: ignite/handlers/**/*
44+
- any-glob-to-any-file: ignite/handlers/**/*
4545

4646
# Add 'metrics' to any changes within 'metrics' folder
4747
"module: metrics":
4848
- changed-files:
49-
- any-glob-to-any-file: ignite/metrics/**/*
49+
- any-glob-to-any-file: ignite/metrics/**/*
5050

5151
-
5252
# Add 'utils' to any changes within 'utils' module
5353
"module: utils":
5454
- changed-files:
55-
- any-glob-to-any-file: ignite/utils.py
55+
- any-glob-to-any-file: ignite/utils.py

.github/workflows/code-style.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ on:
1313
- "!docs/**"
1414
- "!conda.recipe"
1515

16-
1716
jobs:
1817
code-style:
1918
runs-on: ubuntu-latest

.github/workflows/discord_issues.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
workflow_dispatch:
88
inputs:
99
issue_number:
10-
description: 'Issue number'
10+
description: "Issue number"
1111
required: true
1212

1313
permissions:
@@ -26,5 +26,3 @@ jobs:
2626
issue_number: ${{ github.event.inputs.issue_number || github.event.issue.number }}
2727
issue_comment: Hey 👋, I've just created a [thread]($THREAD_LINK$) for this issue on [PyTorch-Ignite Discord](https://pytorch-ignite.ai/chat) where you can quickly talk to the community on the topic.
2828
discord_message: New issue created in `${{ github.repository }}`:<https://github.com/${{ github.repository }}/issues/${{ github.event.issue.number }}>
29-
30-

.github/workflows/discord_pull_requests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
workflow_dispatch:
88
inputs:
99
pull_request_number:
10-
description: 'Pull request number'
10+
description: "Pull request number"
1111
required: true
1212

1313
permissions:

.github/workflows/docker-build.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,12 @@ on:
99
types: [published]
1010
workflow_dispatch:
1111

12-
1312
concurrency:
1413
# <workflow_name>-<branch_name>-<true || commit_sha (if branch is protected)>
1514
group: docker-build-publish-${{ github.ref_name }}-${{ !(github.ref_protected) || github.sha }}
1615
cancel-in-progress: true
1716

1817
jobs:
19-
2018
setup:
2119
name: Setup
2220
runs-on: ubuntu-latest
@@ -46,7 +44,6 @@ jobs:
4644
echo "pth_version=$(python -c "import configparser; cfg=configparser.ConfigParser(); cfg.read('docker.cfg'); print(cfg.get('DEFAULT', 'build_docker_image_pytorch_version'))")" >> $GITHUB_OUTPUT
4745
echo "hvd_version=$(python -c "import configparser; cfg=configparser.ConfigParser(); cfg.read('docker.cfg'); print(cfg.get('DEFAULT', 'build_docker_image_hvd_version'))")" >> $GITHUB_OUTPUT
4846
49-
5047
build-hvd:
5148
name: Build all Horovod flavoured PyTorch-Ignite images
5249
needs: setup
@@ -106,7 +103,6 @@ jobs:
106103
bash push_all.sh hvd-vision
107104
bash push_all.sh hvd-nlp
108105
109-
110106
build-hvd-apex:
111107
name: Build all Horovod + Apex flavoured PyTorch-Ignite images
112108
needs: setup
@@ -166,7 +162,6 @@ jobs:
166162
bash push_all.sh hvd-apex-vision
167163
bash push_all.sh hvd-apex-nlp
168164
169-
170165
build-main:
171166
name: Build all PyTorch-Ignite images
172167
needs: setup
@@ -226,7 +221,6 @@ jobs:
226221
bash push_all.sh vision
227222
bash push_all.sh nlp
228223
229-
230224
build-main-apex:
231225
name: Build all PyTorch-Ignite images with Apex
232226
needs: setup

.github/workflows/pytorch-version-tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
python-version: [3.9, "3.10", "3.11"]
19-
pytorch-version:
20-
[2.5.1, 2.4.1, 2.3.1, 2.2.2, 1.13.1, 1.12.1, 1.10.0]
19+
pytorch-version: [2.5.1, 2.4.1, 2.3.1, 2.2.2, 1.13.1, 1.12.1, 1.10.0]
2120
exclude:
2221
- pytorch-version: 1.10.0
2322
python-version: "3.10"

.github/workflows/triage.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ jobs:
1919
with:
2020
configuration-path: .github/pr-labeler-config.yml
2121
repo-token: "${{ secrets.GITHUB_TOKEN }}"
22-
2322
# Turned off due to unexpected behavior on issue opening+labeling? https://github.com/pytorch/ignite/issues/1836
2423
# - name: Welcome
2524
# uses: actions/first-interaction@v1

.pre-commit-config.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
exclude: "^conda.recipe|assets"
1+
exclude: "^conda.recipe|assets|docs"
22
repos:
33
- repo: https://github.com/pre-commit/pre-commit-hooks
44
rev: v5.0.0
@@ -20,6 +20,7 @@ repos:
2020
# Run the linter
2121
- id: ruff-check
2222
types_or: [python, pyi]
23+
# TODO: Enable when black and ruff format converge
2324
# Run the formatter
2425
# - id: ruff-format
2526
# types_or: [python, pyi]

CONTRIBUTING.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,25 +80,28 @@ conda activate pytorch-ignite-dev
8080

8181
### Installation
8282

83-
1) Make a fork of the repository on the GitHub (see [here](https://github.com/firstcontributions/first-contributions#fork-this-repository) for details).
84-
As a result, for example your username is `happy-ignite-developer`, then you should be able to see your fork on the GitHub, e.g https://github.com/happy-ignite-developer/ignite.git
83+
1. Make a fork of the repository on the GitHub (see [here](https://github.com/firstcontributions/first-contributions#fork-this-repository) for details).
84+
As a result, for example your username is `happy-ignite-developer`, then you should be able to see your fork on the GitHub, e.g https://github.com/happy-ignite-developer/ignite.git
8585

86-
2) Clone your fork locally and setup `upstream`. Assuming your username is `happy-ignite-developer`:
86+
2. Clone your fork locally and setup `upstream`. Assuming your username is `happy-ignite-developer`:
8787

8888
```bash
8989
git clone https://github.com/happy-ignite-developer/ignite.git
9090
cd ignite
9191
git remote add upstream https://github.com/pytorch/ignite.git
9292
git remote -v
9393
```
94+
9495
You might see the following output:
96+
9597
```
9698
origin https://github.com/happy-ignite-developer/ignite.git (fetch)
9799
origin https://github.com/happy-ignite-developer/ignite.git (push)
98100
upstream https://github.com/pytorch/ignite (fetch)
99101
upstream https://github.com/pytorch/ignite (push)
100102
```
101-
3) Sync and install all necessary dependencies:
103+
104+
3. Sync and install all necessary dependencies:
102105

103106
```bash
104107
git pull upstream master
@@ -287,9 +290,7 @@ for formatting docstrings, specially from an example of `Google style with Pytho
287290
- [`.. versionchanged::`] directive for adding new arguments, changing internal behaviours, fixing bugs and
288291
- [`.. deprecated::`] directive for deprecations.
289292

290-
Examples: ``versionadded`` usage [link](https://github.com/pytorch/ignite/blob/52c69251dd9d97c32da1df0477ec3854e5702029/ignite/handlers/state_param_scheduler.py#L24), ``versionchanged`` usage [link](https://github.com/pytorch/ignite/blob/d2020e4e253ac1455a757c2db895c68ccfd2b958/ignite/metrics/metric.py#L281-L282)
291-
292-
293+
Examples: `versionadded` usage [link](https://github.com/pytorch/ignite/blob/52c69251dd9d97c32da1df0477ec3854e5702029/ignite/handlers/state_param_scheduler.py#L24), `versionchanged` usage [link](https://github.com/pytorch/ignite/blob/d2020e4e253ac1455a757c2db895c68ccfd2b958/ignite/metrics/metric.py#L281-L282)
293294

294295
Length of line inside docstrings block must be limited to 120 characters.
295296

docker/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ Available Tensor Operations:
5050
- `docker pull pytorchignite/hvd-apex-nlp:latest`
5151

5252
**Deprecated images** (no version updates)
53+
5354
- [msdp/Dockerfile.msdp-apex-base](msdp/Dockerfile.msdp-apex): multi-stage MSDeepSpeed build with latest Pytorch, Ignite image with minimal dependencies
5455
- `docker pull pytorchignite/msdp-apex:latest`
5556
- [msdp/Dockerfile.msdp-apex-vision](msdp/Dockerfile.msdp-apex-vision): base MSDeepSpeed build with useful computer vision libraries

0 commit comments

Comments
 (0)