Skip to content

Commit dd72a20

Browse files
authored
[Pytorch Operator MicroBenchmark] Boost new UI as primary dashboard (#7426)
1. Mark old UI as playground and boost new dashboard as main dashboard 2. change latency comparison policy to show regression only when it's 25% slower
1 parent 43fa0a6 commit dd72a20

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

torchci/components/benchmark_v3/configs/teams/torchao/config.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { BenchmarkUIConfig } from "lib/benchmark/store/benchmark_config_book";
2+
import { BenchmarkComparisonPolicyConfig } from "../../helpers/RegressionPolicy";
23
import {
34
DEFAULT_COMPARISON_TABLE_METADATA_COLUMNS,
45
DEFAULT_DASHBOARD_BENCHMARK_INITIAL,
5-
DEFAULT_LATENCY_POLICY,
66
} from "../defaults/default_dashboard_config";
77

88
export const PYTORCH_OPERATOR_MICROBENCHMARK_ID =
@@ -19,6 +19,16 @@ const initialOptions = {
1919
},
2020
};
2121

22+
export const LATENCY_POLICY: BenchmarkComparisonPolicyConfig = {
23+
target: "latency",
24+
type: "ratio",
25+
ratioPolicy: {
26+
badRatio: 1.25,
27+
goodRatio: 0.75,
28+
direction: "down",
29+
},
30+
};
31+
2232
const COMPARISON_TABLE_METADATA_COLUMNS = [
2333
...DEFAULT_COMPARISON_TABLE_METADATA_COLUMNS,
2434
{
@@ -98,7 +108,7 @@ export const PytorchOperatorMicroBenchmarkDashoboardConfig: BenchmarkUIConfig =
98108
displayName: "Model",
99109
},
100110
comparisonPolicy: {
101-
latency: DEFAULT_LATENCY_POLICY,
111+
latency: LATENCY_POLICY,
102112
},
103113
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
104114
renderOptions: {
@@ -137,7 +147,7 @@ export const PytorchOperatorMicroBenchmarkDashoboardConfig: BenchmarkUIConfig =
137147
},
138148
},
139149
comparisonPolicy: {
140-
latency: DEFAULT_LATENCY_POLICY,
150+
latency: LATENCY_POLICY,
141151
},
142152
extraMetadata: COMPARISON_TABLE_METADATA_COLUMNS,
143153
renderOptions: {

torchci/components/benchmark_v3/pages/BenchmarkListPage.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,14 @@ export const categories: BenchmarkCategoryGroup[] = [
6060
},
6161
{
6262
name: "Operator Microbenchmark",
63-
route:
64-
"/benchmark/llms?repoName=pytorch%2Fpytorch&benchmarkName=PyTorch+operator+microbenchmark",
63+
route: "/benchmark/v3/dashboard/pytorch_operator_microbenchmark",
6564
info: "Powered by [code](https://github.com/pytorch/pytorch/tree/main/benchmarks/operator_benchmark)",
65+
description:
66+
"Use `legacy page` to see comparison view for different branches. It will be deprecated soon",
6667
actions: [
6768
{
68-
label: "New dashboard (WIP)",
69-
href: "/benchmark/v3/dashboard/pytorch_operator_microbenchmark",
69+
label: "Legacy Page/Playground",
70+
href: "/benchmark/llms?repoName=pytorch%2Fpytorch&benchmarkName=PyTorch+operator+microbenchmark",
7071
},
7172
],
7273
},

0 commit comments

Comments
 (0)