Skip to content

Commit 5fc361b

Browse files
committed
remove use_for_integration_test
1 parent 2dfda3e commit 5fc361b

File tree

8 files changed

+20
-48
lines changed

8 files changed

+20
-48
lines changed

.github/workflows/integration_test_8gpu_core.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 8 GPU Integration Test
1+
name: 8 GPU Integration Test - Core Functionality
22

33
on:
44
push:

.github/workflows/integration_test_8gpu_parallelsim.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 8 GPU Integration Test
1+
name: 8 GPU Integration Test - Model Parallelism
22

33
on:
44
push:

torchtitan/config_manager.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ class Job:
4141
description: str = "default job"
4242
"""Description of the job"""
4343

44-
use_for_integration_test: bool = False
45-
"""Add this config to the integration test suite"""
46-
4744
print_args: bool = False
4845
"""Print the args to terminal"""
4946

torchtitan/experiments/deepseek_v3/train_configs/deepseek_v2.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
dump_folder = "./outputs"
33
description = "DeepSeek v2 debug training"
44
print_args = false
5-
use_for_integration_test = true
65

76
[profiling]
87
enable_profiling = false

torchtitan/experiments/flux/tests/integration_tests.py

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
logging.basicConfig(level=logging.INFO)
1616
logger = logging.getLogger(__name__)
1717

18-
try:
19-
import tomllib
20-
except ModuleNotFoundError:
21-
import tomli as tomllib
22-
2318

2419
def build_test_list():
2520
"""
@@ -138,21 +133,15 @@ def run_tests(args):
138133
for config_file in os.listdir(args.config_dir):
139134
if config_file.endswith(".toml"):
140135
full_path = os.path.join(args.config_dir, config_file)
141-
with open(full_path, "rb") as f:
142-
config = tomllib.load(f)
143-
is_integration_test = config["job"].get(
144-
"use_for_integration_test", False
145-
)
146-
if is_integration_test:
147-
for test_flavor in integration_tests_flavors[config_file]:
148-
if args.test == "all" or test_flavor.test_name == args.test:
149-
if args.ngpu < test_flavor.ngpu:
150-
logger.info(
151-
f"Skipping test {test_flavor.test_name} that requires {test_flavor.ngpu} gpus,"
152-
f" because --ngpu arg is {args.ngpu}"
153-
)
154-
else:
155-
run_test(test_flavor, full_path, args.output_dir)
136+
for test_flavor in integration_tests_flavors[config_file]:
137+
if args.test == "all" or test_flavor.test_name == args.test:
138+
if args.ngpu < test_flavor.ngpu:
139+
logger.info(
140+
f"Skipping test {test_flavor.test_name} that requires {test_flavor.ngpu} gpus,"
141+
f" because --ngpu arg is {args.ngpu}"
142+
)
143+
else:
144+
run_test(test_flavor, full_path, args.output_dir)
156145

157146

158147
def main():

torchtitan/experiments/flux/train_configs/debug_model.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
dump_folder = "./outputs"
44
description = "Flux debug model"
55
print_args = false
6-
use_for_integration_test = true
76

87
[profiling]
98
enable_profiling = false

torchtitan/experiments/llama4/train_configs/debug_model.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
dump_folder = "./outputs"
33
description = "Llama 4 debug training"
44
print_args = false
5-
use_for_integration_test = true
65

76
[profiling]
87
enable_profiling = false

torchtitan/experiments/simple_fsdp/tests/integration_tests.py

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
logging.basicConfig(level=logging.INFO)
1616
logger = logging.getLogger(__name__)
1717

18-
try:
19-
import tomllib
20-
except ModuleNotFoundError:
21-
import tomli as tomllib
22-
2318

2419
def build_test_list():
2520
"""
@@ -244,21 +239,15 @@ def run_tests(args):
244239
for config_file in os.listdir(args.config_dir):
245240
if config_file.endswith(".toml"):
246241
full_path = os.path.join(args.config_dir, config_file)
247-
with open(full_path, "rb") as f:
248-
config = tomllib.load(f)
249-
is_integration_test = config["job"].get(
250-
"use_for_integration_test", False
251-
)
252-
if is_integration_test:
253-
for test_flavor in integration_tests_flavors[config_file]:
254-
if args.test == "all" or test_flavor.test_name == args.test:
255-
if args.ngpu < test_flavor.ngpu:
256-
logger.info(
257-
f"Skipping test {test_flavor.test_name} that requires {test_flavor.ngpu} gpus,"
258-
f" because --ngpu arg is {args.ngpu}"
259-
)
260-
else:
261-
run_test(test_flavor, full_path, args.output_dir)
242+
for test_flavor in integration_tests_flavors[config_file]:
243+
if args.test == "all" or test_flavor.test_name == args.test:
244+
if args.ngpu < test_flavor.ngpu:
245+
logger.info(
246+
f"Skipping test {test_flavor.test_name} that requires {test_flavor.ngpu} gpus,"
247+
f" because --ngpu arg is {args.ngpu}"
248+
)
249+
else:
250+
run_test(test_flavor, full_path, args.output_dir)
262251

263252

264253
def main():

0 commit comments

Comments
 (0)