[compiler toolkit] Add integration tests for compiler toolkit experiments #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
3 times, most recently
from
7a8fdd2 to
18846fa
Compare
yiming0416
changed the title
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
2 times, most recently
from
856f2b5 to
12abb14
Compare
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
3 times, most recently
from
96fe052 to
351a6eb
Compare
yiming0416
changed the title
yiming0416
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
from
351a6eb to
57932ed
Compare
SherlockNoMad
approved these changes
Oct 29, 2025
wwwjn
reviewed
Oct 29, 2025
Contributor
wwwjn
left a comment
wwwjn
left a comment
There was a problem hiding this comment.
Thank you!
nit: please add a badge here as well: https://github.com/pytorch/torchtitan/tree/main/torchtitan/experiments#current-experiments
torchtitan/experiments/compiler_toolkit/tests/integration_tests.py
Outdated
Show resolved
Hide resolved
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
from
57932ed to
bb122fe
Compare
wwwjn
reviewed
Oct 29, 2025
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
from
bb122fe to
95b32b7
Compare
wwwjn
approved these changes
Oct 29, 2025
| ], | ||
| "llama3 FSDP+TP+FlexAttn", | ||
| "llama3_fsdp_tp_flexattn", | ||
| ngpu=8, |
Contributor
There was a problem hiding this comment.
Sorry I have one last comment - Can we use 4 GPUs with FSDP=2, TP=2, I feel like it's better to lower the GPU usage for CI which might help run it faster. Then we could change --ngpu 8 in yaml file to be --ngpu 4
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
2 times, most recently
from
6de1893 to
677394e
Compare
yiming0416
force-pushed
the
yiming/compiler_toolkit_integration_tests
branch
from
677394e to
f3c6733
Compare
jquesnelle
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Nov 10, 2025
…ents (pytorch#1944) Add integration tests for compiler toolkit experiments on llama3 and deepseek_v3 models to guard regressions taking over from pytorch#1953 Newly added Compiler Toolkit 8 GPU Integration Tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests for compiler toolkit experiments on llama3 and deepseek_v3 models to guard regressions
taking over from #1953
Newly added Compiler Toolkit 8 GPU Integration Tests passed