From 339e4ac1f08e4c2370e967c8430c202ee90896f9 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 02:54:54 +0000 Subject: [PATCH 01/16] The error was in line 27 --- 01_challenge/01_challenge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/01_challenge/01_challenge.py b/01_challenge/01_challenge.py index 2d40fa5..f856397 100644 --- a/01_challenge/01_challenge.py +++ b/01_challenge/01_challenge.py @@ -24,7 +24,7 @@ def fizzbuzz(max_num): # % or modulo division gives you the remainder if i%num1==0 and i%num2==0: print(i,three_mul+five_mul) - elif i%num1=0: + elif i%num1==0: print(i,three_mul) elif i%num2==0: print(i,five_mul) From 15f07a86455163c50dfbd94bdcd2ba4b4d5c8593 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 02:56:37 +0000 Subject: [PATCH 02/16] updated readme --- 01_challenge/01_readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/01_challenge/01_readme.md b/01_challenge/01_readme.md index e69de29..7de5f89 100644 --- a/01_challenge/01_readme.md +++ b/01_challenge/01_readme.md @@ -0,0 +1 @@ +The error was because the assignment operator was '=' instead of '==' \ No newline at end of file From c75714201984df576cb1320b9ba24b68dddb304e Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 02:58:12 +0000 Subject: [PATCH 03/16] Found the error it was a missing argument --- 02_challenge/02_challenge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/02_challenge/02_challenge.py b/02_challenge/02_challenge.py index b41cd50..0a14fd2 100644 --- a/02_challenge/02_challenge.py +++ b/02_challenge/02_challenge.py @@ -23,4 +23,4 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': - fizzbuzz() + fizzbuzz(10) From 86eccd2a1e2ef4cec7a29b805b532afccbb3509f Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 02:58:49 +0000 Subject: [PATCH 04/16] update on readme --- 02_challenge/02_readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/02_challenge/02_readme.md b/02_challenge/02_readme.md index e69de29..13fc4ef 100644 --- a/02_challenge/02_readme.md +++ b/02_challenge/02_readme.md @@ -0,0 +1 @@ +The error was not adding an argument \ No newline at end of file From 34a0eebcf0f5097463c24f2341803d2b62051914 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 03:00:41 +0000 Subject: [PATCH 05/16] challenge 3 fixed --- 03_challenge/03_challenge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/03_challenge/03_challenge.py b/03_challenge/03_challenge.py index 6e67d1f..5dfc8b8 100644 --- a/03_challenge/03_challenge.py +++ b/03_challenge/03_challenge.py @@ -12,7 +12,7 @@ def fizzbuzz(max_num): "This method implements FizzBuzz" # Google for 'range in python' to see what it does - for i in range(1,max_num): + for i in range(1,int(max_num)): # % or modulo division gives you the remainder if i%3==0 and i%5==0: print(i,"fizzbuzz") From 52e693ec1603a0d8ae3a21b7ed49016f26aff7d6 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 03:02:10 +0000 Subject: [PATCH 06/16] readme for challenge 3 --- 03_challenge/03_readme.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/03_challenge/03_readme.md b/03_challenge/03_readme.md index e69de29..be9fce0 100644 --- a/03_challenge/03_readme.md +++ b/03_challenge/03_readme.md @@ -0,0 +1,3 @@ +The error was the argument was a string +So i converted that string to an integer +for it to be accepted as an argument for the range.... \ No newline at end of file From 01635baf40d6f4652c29a4ab2d70bcb3c67d5f10 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 03:03:42 +0000 Subject: [PATCH 07/16] challenge 4 solved --- 04_challenge/04_challenge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/04_challenge/04_challenge.py b/04_challenge/04_challenge.py index a3f5edf..f856397 100644 --- a/04_challenge/04_challenge.py +++ b/04_challenge/04_challenge.py @@ -23,7 +23,7 @@ def fizzbuzz(max_num): for i in range(1,max_num): # % or modulo division gives you the remainder if i%num1==0 and i%num2==0: - print(i,three_mul+five_mul) + print(i,three_mul+five_mul) elif i%num1==0: print(i,three_mul) elif i%num2==0: From ebbd81254a1425ebdc6d14816b9adea0a7a479a5 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 03:04:11 +0000 Subject: [PATCH 08/16] readme for challenge 4 --- 04_challenge/readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/04_challenge/readme.md b/04_challenge/readme.md index e69de29..41143fb 100644 --- a/04_challenge/readme.md +++ b/04_challenge/readme.md @@ -0,0 +1 @@ +Indentation error \ No newline at end of file From d2427daef0a4e7b2220df6eff3a09547d30de3e9 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 03:08:37 +0000 Subject: [PATCH 09/16] readme for challenge 5 --- 05_challenge/05_challenge.py | 2 +- 05_challenge/05_readme.md | 1 + 05_challenge/mifile.txt | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 05_challenge/mifile.txt diff --git a/05_challenge/05_challenge.py b/05_challenge/05_challenge.py index 0f9bdbd..9d34355 100644 --- a/05_challenge/05_challenge.py +++ b/05_challenge/05_challenge.py @@ -18,7 +18,7 @@ def fizzbuzz(max_num): three_mul = 'fizz' five_mul = 'buzz' with open('mifile.txt','r') as f: - print 'i have created' + print ('i have created') num1 = int(f.readline()) num2=int(f.readline()) max_num = int(f.readline()) diff --git a/05_challenge/05_readme.md b/05_challenge/05_readme.md index e69de29..c04a05e 100644 --- a/05_challenge/05_readme.md +++ b/05_challenge/05_readme.md @@ -0,0 +1 @@ +ADDED MY OWN FILE.TXT \ No newline at end of file diff --git a/05_challenge/mifile.txt b/05_challenge/mifile.txt new file mode 100644 index 0000000..866bffc --- /dev/null +++ b/05_challenge/mifile.txt @@ -0,0 +1 @@ +dfjdlfdf;kdj/f/FDJ \ No newline at end of file From a0a83f19e7f47e43f2a8f3db0cb1bbd8cc91c5d7 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 03:10:19 +0000 Subject: [PATCH 10/16] Challenge 6 --- 06_challenge/06_challenge.py | 2 +- 06_challenge/06_readme.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/06_challenge/06_challenge.py b/06_challenge/06_challenge.py index b09e24e..d8d4483 100644 --- a/06_challenge/06_challenge.py +++ b/06_challenge/06_challenge.py @@ -18,7 +18,7 @@ def fizzbuzz(max_num): three_mul = 'fizz' five_mul = 'buzz' num1 = conf.num1 - num2 = conf.num + num2 = conf.num2 # Google for 'range in python' to see what it does for i in range(1,max_num): # % or modulo division gives you the remainder diff --git a/06_challenge/06_readme.md b/06_challenge/06_readme.md index e69de29..2b4f58f 100644 --- a/06_challenge/06_readme.md +++ b/06_challenge/06_readme.md @@ -0,0 +1 @@ +Logical error \ No newline at end of file From c583c1ff76fc2b869ea930e8d4e9f76f89a8729b Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 13:22:31 +0000 Subject: [PATCH 11/16] challenge 8 --- 08_challenge/08_challenge.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/08_challenge/08_challenge.py b/08_challenge/08_challenge.py index a7147d2..cca988a 100644 --- a/08_challenge/08_challenge.py +++ b/08_challenge/08_challenge.py @@ -35,6 +35,5 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': "Initialize the fizzbuzz object" - fizzbuzz_obj = Fizz_Buzz() - fizzbuzz_obj.fizzbuzz(100) + fizzbuzz(345) From c783f597bebcca0c5a8269f30c2f04dd45e8f4b1 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 20:08:35 +0000 Subject: [PATCH 12/16] Challenge 13 --- 09_challenge/09_challenge.py | 2 ++ 13_challenge/13_challenge.py | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/09_challenge/09_challenge.py b/09_challenge/09_challenge.py index 37609a3..b64f14d 100644 --- a/09_challenge/09_challenge.py +++ b/09_challenge/09_challenge.py @@ -32,3 +32,5 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': fizzbuzz(100) + + diff --git a/13_challenge/13_challenge.py b/13_challenge/13_challenge.py index e7828f6..f856397 100644 --- a/13_challenge/13_challenge.py +++ b/13_challenge/13_challenge.py @@ -14,13 +14,13 @@ def fizzbuzz(max_num): # adding some redundant declarations on purpose # we will make our script 'tighter' in one of coming exercises - three_mul = 'fizz + three_mul = 'fizz' five_mul = 'buzz' num1 = 3 num2 = 5 # Google for 'range in python' to see what it does - for i in range(1,max_num) + for i in range(1,max_num): # % or modulo division gives you the remainder if i%num1==0 and i%num2==0: print(i,three_mul+five_mul) @@ -31,4 +31,4 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': - fizzbuzzy(100) + fizzbuzz(100) From bde7305d071b632985d03951feb2523861dd84f2 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 20:09:49 +0000 Subject: [PATCH 13/16] Readme for challenge 13 --- 13_challenge/13_readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/13_challenge/13_readme.md b/13_challenge/13_readme.md index e69de29..d329d5e 100644 --- a/13_challenge/13_readme.md +++ b/13_challenge/13_readme.md @@ -0,0 +1 @@ +3 syntax errors \ No newline at end of file From 6e7e1a5d1ab68641b9a9ff893d577b2cd3550c75 Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 20:12:13 +0000 Subject: [PATCH 14/16] Challenge 10 --- 10_challenge/10_challenge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/10_challenge/10_challenge.py b/10_challenge/10_challenge.py index 7d1edf8..ebe118d 100644 --- a/10_challenge/10_challenge.py +++ b/10_challenge/10_challenge.py @@ -8,7 +8,7 @@ # print buzz for multiples of 5 # print fizzbuzz for multiples of 3 and 5" """ -import fizzbuzz +from fizzbuzz import fizzbuzz #----START OF SCRIPT if __name__=='__main__': From 24a08ff6dad87cbd0daddeaf01e30cdbc09ccaea Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 20:14:29 +0000 Subject: [PATCH 15/16] Challenge 8 --- 08_challenge/08_challenge.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/08_challenge/08_challenge.py b/08_challenge/08_challenge.py index cca988a..5fb5010 100644 --- a/08_challenge/08_challenge.py +++ b/08_challenge/08_challenge.py @@ -12,7 +12,7 @@ class Fizz_Buzz: "Class to implement FizzBuzz for multiples of 3 and 5" - def fizzbuzz(max_num): + def fizzbuzz(self,max_num): "This method implements FizzBuzz" # adding some redundant declarations on purpose @@ -35,5 +35,6 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': "Initialize the fizzbuzz object" - fizzbuzz(345) + new_object = Fizz_Buzz() + new_object.fizzbuzz(345) From a0c22cada2c334e11f448f8d4f7a2ec2b4027dbc Mon Sep 17 00:00:00 2001 From: jatta-njie21 Date: Fri, 29 May 2020 20:16:04 +0000 Subject: [PATCH 16/16] Readme for challenge 8 --- 08_challenge/08_readme.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/08_challenge/08_readme.md b/08_challenge/08_readme.md index e69de29..57f7f93 100644 --- a/08_challenge/08_readme.md +++ b/08_challenge/08_readme.md @@ -0,0 +1,5 @@ +First error was adding self to the function + +Second error was creating a new instance of the Fizz_Buzz class + +Using the new new instance to call the methods \ No newline at end of file