Get Rtools data from API (incomplete)

[ci skip]

Author: gaborcsardi

Cargo.lock

@@ -34,6 +34,7 @@ lazy_static = "1.4.0"
 libc = "0.2"
 log = "0.4"
 nix = { version = "0.28.0", features = ["fs", "user"] }
+once_cell = "1.21.3"
 path-clean = "1.0.1"
 rand = "0.8.5"
 regex = "1.5.4"

Cargo.toml

@@ -0,0 +1,13 @@
+
+use once_cell::sync::Lazy;
+use serde_json::{json, Value};
+
+pub static HC_RTOOLS_AARCH64: Lazy<Value> = Lazy::new(|| {
+    let data = include_str!("json/rtools-versions-aarch64.json");
+    serde_json::from_str(data).expect("Invalid JSON in json/rtools-versions-aarch64.json")
+});
+
+pub static HC_RTOOLS: Lazy<Value> = Lazy::new(|| {
+    let data = include_str!("json/rtools-versions.json");
+    serde_json::from_str(data).expect("Invalid JSON in json/rtools-versions.json")
+});

src/hardcoded.rs

@@ -0,0 +1 @@
+[{"version":"44","url":"https://github.com/r-hub/rtools44/releases/download/latest/rtools44-aarch64.exe","first":"4.4.0","last":"4.4.100"},{"version":"45","url":"https://github.com/r-hub/rtools45/releases/download/latest/rtools45-aarch64.exe","first":"4.5.0","last":"100.0.0"}]

src/json/rtools-versions-aarch64.json

@@ -0,0 +1 @@
+[{"version":"26","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools26.exe","first":"2.0.0","last":"2.6.2"},{"version":"27","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools27.exe","first":"2.6.0","last":"2.7.2"},{"version":"28","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools28.exe","first":"2.7.0","last":"2.8.1"},{"version":"29","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools29.exe","first":"2.8.0","last":"2.9.2"},{"version":"210","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools210.exe","first":"2.9.0","last":"2.10.1"},{"version":"211","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools211.exe","first":"2.10.0","last":"2.11.1"},{"version":"212","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools212.exe","first":"2.12.0","last":"2.12.2"},{"version":"213","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools213.exe","first":"2.13.0","last":"2.13.2"},{"version":"214","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools214.exe","first":"2.13.0","last":"2.14.2"},{"version":"215","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools215.exe","first":"2.14.2","last":"2.15.1"},{"version":"30","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools30.exe","first":"2.15.2","last":"3.0.3"},{"version":"31","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools31.exe","first":"3.0.0","last":"3.1.3"},{"version":"32","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools32.exe","first":"3.1.0","last":"3.2.5"},{"version":"33","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools33.exe","first":"3.2.0","last":"3.3.3"},{"version":"34","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools34.exe","first":"3.3.0","last":"3.6.3"},{"version":"35","url":"https://cran.rstudio.com/bin/windows/Rtools/Rtools35.exe","first":"3.3.0","last":"3.6.3"},{"version":"40","url":"https://cran.rstudio.com/bin/windows/Rtools/rtools40-x86_64.exe","first":"4.0.0","last":"4.2.100"},{"version":"42","url":"https://github.com/r-hub/rtools42/releases/download/latest/rtools42.exe","first":"4.2.0","last":"4.2.100"},{"version":"43","url":"https://github.com/r-hub/rtools43/releases/download/latest/rtools43.exe","first":"4.3.0","last":"4.3.100"},{"version":"44","url":"https://github.com/r-hub/rtools44/releases/download/latest/rtools44.exe","first":"4.4.0","last":"4.4.100"},{"version":"45","url":"https://github.com/r-hub/rtools45/releases/download/latest/rtools45.exe","first":"4.5.0","last":"100.0.0"}]

src/json/rtools-versions.json

@@ -20,6 +20,7 @@ mod common;
 mod config;
 mod download;
 mod escalate;
+mod hardcoded;
 mod library;
 mod macos;
 mod renv;

src/lib.rs

@@ -33,6 +33,7 @@ mod library;
 mod common;
 mod config;
 mod download;
+mod hardcoded;
 mod renv;
 mod resolve;
 mod rversion;

src/main.rs

@@ -3,13 +3,18 @@ use std::error::Error;
 
 use clap::ArgMatches;
 use simple_error::bail;
+use simplelog::*;
+use std::sync::{LazyLock, RwLock};
+use serde_json::{json, Map, Value};
 
 use crate::common::*;
 use crate::download::*;
 use crate::rversion::*;
 use crate::utils::*;
+use crate::hardcoded::*;
 
 const API_URI: &str = "https://api.r-hub.io/rversions/resolve/";
+const API_ROOT: &str = "https://api.r-hib.io/rversions/";
 
 pub fn get_resolve(args: &ArgMatches) -> Result<Rversion, Box<dyn Error>> {
     let platform = get_platform(args)?;
@@ -91,3 +96,77 @@ async fn resolve_version(
         ppmurl: ppmurl
     })
 }
+
+static API_CACHE: LazyLock<RwLock<Map<String, Value>>> = LazyLock::new(|| {
+    RwLock::new(Map::new())
+});
+
+fn cache_set_value(key: &str, value: Value) {
+    let mut map = API_CACHE.write().unwrap();
+    map.insert(key.to_string(), value);
+}
+
+fn cache_get_value(key: &str) -> Option<Value> {
+    let map = API_CACHE.read().unwrap();
+    map.get(key).cloned()
+}
+
+pub fn get_rtools_versions(arch: &str) -> serde_json::Value {
+    let cache_key = "rtools".to_string() + arch;
+    let value = match cache_get_value(&cache_key) {
+	Some(cached) => cached,
+	None => {
+	    let url = API_ROOT.to_string() + "/rtools-versions/" + arch;
+	    let val = match download_json_sync(vec![url]) {
+		Ok(dl) => {
+		    cache_set_value(&cache_key, dl[0].clone());
+		    dl[0].clone()
+		},
+		Err(x) => {
+		    warn!("Failed to download Rtools version data, will use \
+			   hardcoded data instead.");
+		    if arch == "aarch64" {
+			HC_RTOOLS_AARCH64.clone()
+		    } else {
+			HC_RTOOLS.clone()
+		    }
+		}
+	    };
+	    val
+	}
+    };
+
+    value
+}
+
+pub fn get_rtools_version(version: &str, arch: &str)
+			  -> Result<RtoolsVersion, Box<dyn Error>> {
+
+    let value = get_rtools_versions(arch);
+
+    let msg = "Cannot parse response from the R version API to learn about \
+	       Rtools versions";
+
+    let value = match value.as_array() {
+	Some(x) => x,
+	None => bail!(msg)
+    };
+
+
+    for ver in value {
+	let versionx: String = ver["version"].as_str().ok_or(msg)?.to_string();
+	if &versionx == version {
+	    let url: String = ver["url"].as_str().ok_or(msg)?.to_string();
+	    let first: String = ver["first"].as_str().ok_or(msg)?.to_string();
+	    let last: String = ver["last"].as_str().ok_or(msg)?.to_string();
+	    return Ok(RtoolsVersion {
+		version: versionx,
+		url,
+		first,
+		last
+	    });
+	}
+    }
+
+    bail!("Cannot find Rtools version {} for architecture {}", version, arch);
+}

src/resolve.rs

@@ -109,3 +109,12 @@ pub struct LinuxTools {
     pub is_installed: Vec<String>,
     pub delete: Vec<String>,
 }
+
+#[cfg(target_os = "windows")]
+#[derive(Default, Debug)]
+pub struct RtoolsVersion {
+    pub version: String,
+    pub url: String,
+    pub first: String,
+    pub last: String
+}

src/rversion.rs

@@ -164,6 +164,8 @@ fn add_rtools(version: String) -> Result<(), Box<dyn Error>> {
     } else {
         vers = vec![version.replace("rtools", "")];
     }
+    let myarch = arch();
+    let suffix = if myarch == whoami::Arch::Arm64 { "-aarch64" } else { "" };
     let client = &reqwest::Client::new();
     for ver in vers {
 	let rtools45 = &ver[0..2] == "45";
@@ -174,7 +176,8 @@ fn add_rtools(version: String) -> Result<(), Box<dyn Error>> {
         let filename: String;
         let url: String;
 	if rtools45 {
-	    let rt45=Path::new("C:\\Rtools45");
+	    let rt45path = "C:\\Rtools45".to_owned() + suffix;
+	    let rt45=Path::new(&rt45path);
 	    if rt45.exists() {
 		info!("Rtools45 is already installed");
 		continue;
@@ -725,7 +728,7 @@ pub fn sc_set_default(ver: &str) -> Result<(), Box<dyn Error>> {
 
 pub fn unset_default() -> Result<(), Box<dyn Error>> {
     escalate("unsetting the default R version")?;
-    
+
     fn try_rm(x: &str) {
 	let linkdir = Path::new(RIG_LINKS_DIR);
 	let f = linkdir.join(x);