Fix: Path with spaces throws a bad URI(is not URI?) error

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 Get upgrade notes from Sprockets 3.x to 4.x at https://github.com/rails/sprockets/blob/master/UPGRADING.md
 
+## Next Release
+
+- Fix bug where project Path with spaces throws a bad URI(is not URI?) error - Marc Gayle - https://github.com/marcamillion
+
 ## 4.0.2
 
 - Fix `etag` and digest path compilation that were generating string with invalid digest since 4.0.1.

lib/sprockets/uri_utils.rb

@@ -37,13 +37,25 @@ def join_uri(scheme, userinfo, host, port, registry, path, opaque, query, fragme
       URI::Generic.new(scheme, userinfo, host, port, registry, path, opaque, query, fragment).to_s
     end
 
+    # Escaped URI: Return URI regardless of whether the string is initially escaped.
+    #              If the initial URI is escaped, then that gets returned. If not, then it is escaped.
+    #
+    # uri - String uri
+    #
+    # Returns uri
+    def escaped_uri(uri)
+      return uri if uri == URI::Generic::DEFAULT_PARSER.escape(URI::Generic::DEFAULT_PARSER.unescape(uri))
+      URI::Generic::DEFAULT_PARSER.escape(uri)
+    end
+
     # Internal: Parse file: URI into component parts.
     #
     # uri - String uri
     #
     # Returns [scheme, host, path, query].
     def split_file_uri(uri)
-      scheme, _, host, _, _, path, _, query, _ = URI.split(uri)
+      # We need to ensure that the URI being split is always escaped
+      scheme, _, host, _, _, path, _, query, _ = URI.split(escaped_uri(uri))
 
       path = URI::Generic::DEFAULT_PARSER.unescape(path)
       path.force_encoding(Encoding::UTF_8)

test/test_loader.rb

@@ -50,7 +50,7 @@ def setup
   test 'load uri with index alias' do
     filename = fixture_path('default/coffee/index.js')
     index_alias = fixture_path('default/coffee.js')
-    assert asset = @env.load("file://#{uri_path(filename)}?type=application/javascript&index_alias=#{Rack::Utils.escape(index_alias)}")
+    assert asset = @env.load("file://#{uri_path(filename)}?type=application/javascript&index_alias=#{index_alias}")
     assert_equal filename, asset.filename, asset.inspect
     assert_equal 'coffee.js', asset.logical_path, asset.inspect
     assert_equal fixture_path('default'), asset.to_hash[:load_path], asset.inspect

test/test_uri_utils.rb

@@ -35,6 +35,9 @@ def test_inverse_uri_functions
   end
 
   def test_split_file_uri
+    parts = split_file_uri("file:///usr/Company Name Dropbox/local/bin/myapp/assets")
+    assert_equal ['file', nil, '/usr/Company Name Dropbox/local/bin/myapp/assets', nil], parts
+
     parts = split_file_uri("file://localhost/etc/fstab")
     assert_equal ['file', 'localhost', '/etc/fstab', nil], parts