-
Notifications
You must be signed in to change notification settings - Fork 37
Description
This issue tracks general issues related to pulling (via Autobump features) from the new ob-team-charts repo.
As a quick review, the new repo is where the O&B team maintains our Logging & Monitoring charts from their upstream sources. This intermediary location is kept as general as possible and the charts are not intended to be specific to a single Rancher minor version like most charts we make. A necessary measure to ensure our Rancher Minor specific changes/patches don't break updates we sync from upstream.
The way that this repo was setup actually mimics rancher/charts directly and uses the same build scripts (this repo) to produce the charts. Each chart has a -rancher.{number} suffix that O&B team must increment anytime they release a change. This ensures that any changes we make are as traceable as possible within the Rancher ecosystem and are not obscured between Rancher Minor versions.
All that in mind there are currently 2 areas we may need to explore and improve to make auto bumps work for Logging/Monitoring. These are:
- Adjust (or create new) autobump action that allows specifying a commit hash
- This would potentially help us to support Logging/Monitoring
- May still require custom logic for bumping versions w/o issue
- Add auto-bump logic for tracking chart bumps of specific "upstream version"
- Without this 1 may not work alone and could unexpectedly backport newer (upstream) version
Alternatives
I thought Webhook used auto bump, but looking it over I see it doesn't. Digging deeper I found that Tom created an automation (and bot) that Frameworks uses to help automate that task outside of this tooling. Potentially our team should consider re-using that concept here as they a pretty similar - and doing so could give us more flexibility for us to ensure Monitoring updates also include PromFed (and Rancher Project Monitoring).