fix(TextBox): toggleMarquee should not short-circuit if there is no contentTag (#449)

erautenberg · web-flow · commit 0430f1274662 · 2023-12-22T22:47:50.000-05:00
diff --git a/packages/@lightningjs/ui-components/src/components/TextBox/TextBox.js b/packages/@lightningjs/ui-components/src/components/TextBox/TextBox.js
@@ -321,7 +321,7 @@ export default class TextBox extends Base {
   }
 
   _toggleMarquee(contentTag) {
-    if (!contentTag) return;
+    // do not just return if there is no contentTag, we may still need to alpha the Marquee
     if (this.marquee) {
       if (contentTag) {
         contentTag.alpha = 0.001;

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ export default class TextBox extends Base {`
`321`	`321`	`}`
`322`	`322`
`323`	`323`	`_toggleMarquee(contentTag) {`
`324`		`- if (!contentTag) return;`
	`324`	`+ // do not just return if there is no contentTag, we may still need to alpha the Marquee`
`325`	`325`	`if (this.marquee) {`
`326`	`326`	`if (contentTag) {`
`327`	`327`	`contentTag.alpha = 0.001;`