Skip to content

Commit 8f37c50

Browse files
authored
chore: remove hardcoded timezone in e2e tests (#589)
1 parent e9ae918 commit 8f37c50

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

example/App.js

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,9 @@ export const App = () => {
9696

9797
const onChange = (event, selectedDate) => {
9898
const currentDate = selectedDate || date;
99-
100-
setShow(Platform.OS === 'ios');
99+
if (Platform.OS === 'android') {
100+
setShow(false);
101+
}
101102
if (event.type === 'neutralButtonPressed') {
102103
setDate(new Date(0));
103104
} else {
@@ -159,11 +160,15 @@ export const App = () => {
159160
Example DateTime Picker
160161
</ThemedText>
161162
</View>
162-
<ThemedText selectable testID="timeInfo">
163-
TZ: {RNLocalize.getTimeZone()}, TZOffset:{' '}
164-
{new Date().getTimezoneOffset() / 60} original:{' '}
165-
{moment(sourceDate).format('MM/DD/YYYY HH:mm')}
166-
</ThemedText>
163+
<View style={{flexDirection: 'row'}}>
164+
<ThemedText selectable testID="timeInfo">
165+
TZ: {RNLocalize.getTimeZone()}, original:{' '}
166+
{moment(sourceDate).format('MM/DD/YYYY HH:mm')}
167+
</ThemedText>
168+
<ThemedText>
169+
, TZOffset:{new Date().getTimezoneOffset() / 60}
170+
</ThemedText>
171+
</View>
167172
<ThemedText>mode prop:</ThemedText>
168173
<SegmentedControl
169174
values={MODE_VALUES}

example/e2e/detoxTest.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe('e2e tests', () => {
3737

3838
it('timeInfo heading has expected content', async () => {
3939
await expect(elementById('timeInfo')).toHaveText(
40-
'TZ: Europe/Prague, TZOffset: -1 original: 11/13/2021 11:00',
40+
'TZ: Europe/Prague, original: 11/13/2021 11:00',
4141
);
4242
});
4343

@@ -178,14 +178,14 @@ describe('e2e tests', () => {
178178

179179
if (isIOS()) {
180180
const testElement = getDateTimePickerIOS();
181-
await testElement.setColumnToValue(0, '10');
181+
await testElement.setColumnToValue(0, '7');
182182
await testElement.setColumnToValue(1, '30');
183183
await testElement.setColumnToValue(2, 'AM');
184184
} else {
185-
await userChangesTimeValue({hours: '10', minutes: '30'});
185+
await userChangesTimeValue({hours: '7', minutes: '30'});
186186
await userTapsOkButtonAndroid();
187187
}
188-
await expect(getTimeText()).toHaveText('09:30');
188+
await expect(getTimeText()).toHaveText('06:30');
189189
});
190190

191191
it('should let you pick tomorrow but not yesterday when setting min/max', async () => {

0 commit comments

Comments
 (0)