Skip to content

Commit ceb5c8f

Browse files
committed
RHDHBUGS-2005 - Fixed broken link by deactivating an example link and using attributes
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
1 parent bd679f3 commit ceb5c8f

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

artifacts/attributes.adoc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
:my-product-secrets: my-rhdh-secrets
3030
:my-product-database-certificates-secrets: my-rhdh-database-certificates-secrets
3131
:my-product-database-secrets: my-rhdh-database-secrets
32-
:my-product-url: https://__<my_developer_hub_url>__
32+
:my-product-domain: __<my_developer_hub_domain>__
33+
:my-product-url: https://__<my_developer_hub_domain>__
3334
:my-extra-file-configmap: my-project-configmap
3435

3536
// Red Hat Platforms

modules/installation/proc-deploy-rhdh-instance-gke.adoc

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ You need to create an `A` record with the value equal to the IP address. This pr
2121
+
2222
--
2323
.`{my-app-config-file}` fragment
24-
[source,yaml,subs="attributes+"]
24+
[source,yaml,subs="+attributes,+quotes"]
2525
----
2626
apiVersion: v1
2727
kind: ConfigMap
@@ -31,17 +31,17 @@ data:
3131
"{my-app-config-file}": |
3232
app:
3333
title: Red Hat Developer Hub
34-
baseUrl: https://<rhdh_domain_name>
34+
baseUrl: {my-product-url}
3535
backend:
3636
auth:
3737
externalAccess:
3838
- type: legacy
3939
options:
4040
subject: legacy-default-config
4141
secret: "${BACKEND_SECRET}"
42-
baseUrl: https://<rhdh_domain_name>
42+
baseUrl: {my-product-url}
4343
cors:
44-
origin: https://<rhdh_domain_name>
44+
origin: {my-product-url}
4545
----
4646
--
4747

@@ -122,7 +122,7 @@ metadata:
122122
name: <rhdh_certificate_name>
123123
spec:
124124
domains:
125-
- <rhdh_domain_name>
125+
- {my-product-domain}
126126
----
127127
--
128128
For more information about setting up a Google-managed certificate, see https://cloud.google.com/kubernetes-engine/docs/how-to/managed-certs?hl=en#setting_up_a_google-managed_certificate[Setting up a Google-managed certificate].
@@ -149,7 +149,7 @@ For more information about setting a policy to redirect to HTTPS, see https://cl
149149
+
150150
--
151151
.Example of an ingress resource configuration
152-
[source,yaml,subs="attributes+"]
152+
[source,yaml,subs="+attributes,+quotes"]
153153
----
154154
apiVersion: networking.k8s.io/v1
155155
kind: Ingress
@@ -166,7 +166,7 @@ spec:
166166
ingressClassName: gce
167167
rules:
168168
# TODO: Set your application domain name.
169-
- host: <rhdh_domain_name>
169+
- host: {my-product-domain}
170170
http:
171171
paths:
172172
- path: /
@@ -187,7 +187,7 @@ spec:
187187

188188
* Wait for the `ManagedCertificate` to be provisioned. This process can take a couple of hours.
189189

190-
* Access {product-very-short} with `https://<rhdh_domain_name>`
190+
* Access {product-very-short} with `pass:a,q[{my-product-url}]`.
191191

192192
// Wait until the DNS name is responsive, indicating that your {product-short} instance is ready for use.
193193

0 commit comments

Comments
 (0)