-
Notifications
You must be signed in to change notification settings - Fork 192
Update image stream definitions for .NET 10. #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- This adds the '10.0', '10.0-ubi9' tags and updates 'latest' to use 10.0. - For 'dotnet-runtime:10.0', we use the non-web 'ubi9/dotnet-100' image that doesn't include the ASP.NET Core runtime. - An additional 'dotnet-aspnet' ImageStream is introduced which references images that include ASP.NET Core runtime for 8.0, 9.0, and 10.0. - The 'hidden' tag is placed on the '-ubi' suffixed tags to promote using the tags without a suffix. - Since .NET 6 was removed, we no longer need to differentiate between aarch64, ppc64, s390x. This removes the files specific to those architectures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I really like how backward compatibility is handled with the new -aspnet imagestream too.
|
Thanks for the review, @omajid! We won't merge this until .NET 10 container images are available. |
| "name": "dotnet", | ||
| "annotations": { | ||
| "openshift.io/display-name": ".NET" | ||
| "openshift.io/display-name": ".NET SDK" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added SDK to the SDK image display names.
| "openshift.io/display-name": ".NET SDK (Latest)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "description": "Build and run .NET applications. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/9.0/build/README.md.\n\nWARNING: By selecting this tag, your application will automatically update to use the latest version of .NET available on OpenShift, including major version updates.", | ||
| "description": "Build and run applications using the latest .NET SDK. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/10.0/build/README.md.\n\nWARNING: By selecting this tag, your application will automatically update to use the latest version of .NET available on OpenShift, including major version updates.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlight that this is the latest version.
| "openshift.io/display-name": ".NET SDK 10.0 (UBI 9)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "description": "Build and run .NET 8.0 applications on UBI 8. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/8.0/build/README.md.", | ||
| "description": "Build and run .NET 10.0 applications on UBI 9. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/10.0/build/README.md.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was tempted to change this description further, but the pattern for OpenShift s2i images is "Build and run XyZ applications on UBI X." so I sticked to that.
| "openshift.io/display-name": ".NET Runtime (Latest)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "description": "Run .NET applications. For more information about using this image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/9.0/runtime/README.md.\n\nWARNING: By selecting this tag, your application will automatically update to use the latest version of .NET available on OpenShift, including major version updates.", | ||
| "description": "Base image for running non-web .NET applications using the latest .NET runtime. For more information, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/10.0/runtime/README.md.\n\nWARNING: By selecting this tag, your application will automatically update to use the latest version of .NET available on OpenShift, including major version updates. Instead, it is recommended to use the tag that corresponds to the .NET version targeted by your application. Unless configured differently, .NET applications won't start on a different major runtime version.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighting issues with using the latest tag for runtime images.
| "openshift.io/display-name": ".NET 8.0 Runtime (UBI 8)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "description": "Run .NET 8.0 applications on UBI 8. For more information about using this image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/8.0/runtime/README.md.", | ||
| "description": "Base image for running .NET 8.0 applications on UBI 8. For more information, see https://github.com/redhat-developer/s2i-dotnetcore/tree/main/8.0/runtime/README.md.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making more clear that these are base images.
|
The new changes all look good to me! |
This adds the '10.0', '10.0-ubi9' tags and updates 'latest' to use 10.0.
For 'dotnet-runtime:10.0', we use the non-web 'ubi9/dotnet-100' image that doesn't include the ASP.NET Core runtime.
An additional 'dotnet-aspnet' ImageStream is introduced which references images that include ASP.NET Core runtime for 8.0, 9.0, and 10.0.
The 'hidden' tag is placed on the '-ubi' suffixed tags to promote using the tags without a suffix.
Since .NET 6 was removed, we no longer need to differentiate between aarch64, ppc64, s390x. This removes the files specific to those architectures.