Skip to content

Commit 02575de

Browse files
committed
Use Node 20
Node 18 is EOL and has been for a bit, so we should use Node 20 wherever possible. Signed-off-by: David Thompson <[email protected]>
1 parent f6aaeba commit 02575de

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ jobs:
66
runs-on: ubuntu-latest
77
steps:
88
- uses: actions/checkout@v2
9+
- uses: actions/setup-node@v4
10+
with:
11+
node-version: '20'
912
- name: Install dependencies
1013
run: npm i --also=dev
1114
- name: Run TypeScript compiler (under webpack)

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
- name: Set Up NodeJS
8484
uses: actions/setup-node@v4
8585
with:
86-
node-version: '18'
86+
node-version: '20'
8787
- name: Install dependencies
8888
run: npm install -g typescript "@vscode/vsce" "ovsx"
8989
- name: Build vscode-xml

package-lock.json

Lines changed: 11 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"@eslint/js": "^9.16.0",
7979
"@types/fs-extra": "^8.1.2",
8080
"@types/glob": "^7.1.4",
81-
"@types/node": "^18.17.1",
81+
"@types/node": "^20.19.9",
8282
"@types/vscode": "^1.37.0",
8383
"@types/yauzl": "^2.9.1",
8484
"@vscode/test-cli": "^0.0.10",

0 commit comments

Comments
 (0)