Stop passing the filter from the source graph to a target graph during a traversal of an internal subscription graph link if the target graph expects no filter parameter. Otherwise, when a non-bulk subscription occurs, the filter is added to target and will not match the same graph when multiple graph links points at the same target graph and the client will crash with an error like: "Attempt to update channel 1.45.X but channel does not allow dynamic updates of filter and channel has not been explicitly subscribed.".

Author: realityforge

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ### Unreleased
 
+* Stop passing the filter from the source graph to a target graph during a traversal of an internal subscription graph link if the target graph expects no filter parameter. Otherwise, when a non-bulk subscription occurs, the filter is added to target and will not match the same graph when multiple graph links points at the same target graph and the client will crash with an error like: "Attempt to update channel 1.45.X but channel does not allow dynamic updates of filter and channel has not been explicitly subscribed.".
+
 ### [v6.127](https://github.com/replicant4j/replicant/tree/v6.127) (2022-10-03) · [Full Changelog](https://github.com/spritz/spritz/compare/v6.126...v6.127)
 
 Changes in this release:

server/src/main/java/org/realityforge/replicant/server/transport/ReplicantSessionManagerImpl.java

@@ -468,13 +468,13 @@ ChannelLinkEntry createChannelLinkEntryIfRequired( @Nonnull final ReplicantSessi
     if ( null != sourceEntry )
     {
       final ChannelAddress target = link.getTargetChannel();
-      if ( !getSystemMetaData().getChannelMetaData( target ).hasFilterParameter() ||
-           shouldFollowLink( sourceEntry, target ) )
+      final boolean targetHasFilter = getSystemMetaData().getChannelMetaData( target ).hasFilterParameter();
+      if ( !targetHasFilter || shouldFollowLink( sourceEntry, target ) )
       {
         final SubscriptionEntry targetEntry = session.findSubscriptionEntry( target );
         if ( null == targetEntry )
         {
-          return new ChannelLinkEntry( source, link.getTargetChannel(), sourceEntry.getFilter() );
+          return new ChannelLinkEntry( source, link.getTargetChannel(), targetHasFilter ? sourceEntry.getFilter() : null );
         }
         else
         {