Skip to content

Commit b8ca156

Browse files
committed
CI/CD: nightly-release: Don't fail fast
The default strategy is for GItHub CI/CD pipelines is to cancel all runners when one runner observes an error. The idea is to keep the workload of the runners low and an error likely leads to a future source code change (making the results of the other runners irrelevant). This is reasonable for testing PRs with unknown expectation. However, for our nightly release builds, we observe that errors are typically caused by the runners and not by the contents of this repo. Therefore, we address build issues of the nightly releases by re-running all failed builds, which includes those which have been canceled because of the error. Letting all runners complete their build is a better option in this case, as we don't need to re-start builds that would have succeeded. And that's what this patch does. Signed-off-by: Christoph Müllner <[email protected]>
1 parent ac2246a commit b8ca156

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/nightly-release.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ jobs:
4747
if: needs.activity-check.outputs.stale != 'true'
4848
runs-on: ${{ matrix.os }}
4949
strategy:
50+
fail-fast: false
5051
matrix:
5152
os: [ubuntu-22.04, ubuntu-24.04]
5253
mode: [newlib, linux, musl, uclibc]

0 commit comments

Comments
 (0)