Merge branch 'main' of github.com:roc-lang/basic-cli into split-update

Author: Anton-4

Cargo.toml

@@ -5,11 +5,9 @@ members = ["crates/roc_host", "crates/roc_host_lib", "crates/roc_host_bin"]
 [profile.release]
 lto = true
 strip = "debuginfo"
-# Enabling this triggered a segmentation fault (see issue github.com/roc-lang/roc/issues/6121).
-# That issue is notoriously fickle, so disableing this may just happen to shuffle the code enough to avoid it.
-# Try re-enableing this again in the future after some code changes, it may no longer trigger this issue.
-# Setting it to 1 should improve execution speed by making things easier to optimize for LLVM.
-# codegen-units = 1
+# You can comment this out if you hit a segmentation fault similar to the one in see issue github.com/roc-lang/roc/issues/6121
+# Setting this to 1 should improve execution speed by making things easier to optimize for LLVM.
+codegen-units = 1
 
 [workspace.dependencies]
 roc_std = { git = "https://github.com/roc-lang/roc.git" }

crates/roc_host/src/lib.rs

@@ -301,6 +301,7 @@ pub fn init() {
         roc_fx_exePath as _,
         roc_fx_stdinLine as _,
         roc_fx_stdinBytes as _,
+        roc_fx_stdinReadToEnd as _,
         roc_fx_stdoutLine as _,
         roc_fx_stdoutWrite as _,
         roc_fx_stderrLine as _,
@@ -462,8 +463,9 @@ pub extern "C" fn roc_fx_stdinLine() -> RocResult<RocStr, RocStr> {
 
 #[no_mangle]
 pub extern "C" fn roc_fx_stdinBytes() -> RocResult<RocList<u8>, ()> {
+    const BUF_SIZE: usize = 16_384; // 16 KiB = 16 * 1024 = 16,384 bytes
     let stdin = std::io::stdin();
-    let mut buffer: [u8; 256] = [0; 256];
+    let mut buffer: [u8; BUF_SIZE] = [0; BUF_SIZE];
 
     match stdin.lock().read(&mut buffer) {
         Ok(bytes_read) => RocResult::ok(RocList::from(&buffer[0..bytes_read])),

examples/stdin.roc

@@ -6,7 +6,7 @@ import pf.Stdin
 
 main =
     Stdout.line! "Enter a series of number characters (0-9):"
-    numberBytes = takeNumberBytes!
+    numberBytes = readNumberBytes!
 
     if List.isEmpty numberBytes then
         Stderr.line "Expected a series of number characters (0-9)"
@@ -18,8 +18,8 @@ main =
             Err _ ->
                 Stderr.line "Error, bad utf8"
 
-takeNumberBytes : Task (List U8) _
-takeNumberBytes =
+readNumberBytes : Task (List U8) _
+readNumberBytes =
     bytesRead = Stdin.bytes! {}
 
     numberBytes =

platform/File.roc

@@ -153,7 +153,9 @@ readUtf8 = \path ->
 #    Path.read (Path.fromStr path) fmt
 
 ## Returns true if the path exists on disk and is pointing at a directory.
-## Any error will return false.
+## Returns `Task.ok false` if the path exists and it is not a directory. If the path does not exist,
+## this function will return `Task.err PathErr PathDoesNotExist`.
+##
 ## This uses [rust's std::path::is_dir](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_dir).
 ##
 ## > [Path.isDir] does the same thing, except it takes a [Path] instead of a [Str].
@@ -162,7 +164,9 @@ isDir = \path ->
     Path.isDir (Path.fromStr path)
 
 ## Returns true if the path exists on disk and is pointing at a regular file.
-## Any error will return false.
+## Returns `Task.ok false` if the path exists and it is not a file. If the path does not exist,
+## this function will return `Task.err PathErr PathDoesNotExist`.
+##
 ## This uses [rust's std::path::is_file](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_file).
 ##
 ## > [Path.isFile] does the same thing, except it takes a [Path] instead of a [Str].
@@ -171,7 +175,9 @@ isFile = \path ->
     Path.isFile (Path.fromStr path)
 
 ## Returns true if the path exists on disk and is pointing at a symbolic link.
-## Any error will return false.
+## Returns `Task.ok false` if the path exists and it is not a symbolic link. If the path does not exist,
+## this function will return `Task.err PathErr PathDoesNotExist`.
+##
 ## This uses [rust's std::path::is_symlink](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_symlink).
 ##
 ## > [Path.isSymLink] does the same thing, except it takes a [Path] instead of a [Str].

platform/Path.roc

@@ -418,7 +418,10 @@ display = \path ->
 # Path.isDir, etc.
 
 ## Returns true if the path exists on disk and is pointing at a directory.
-## Any error will return false.
+## Returns `Task.ok false` if the path exists and it is not a directory. If the path does not exist,
+## this function will return `Task.err PathErr PathDoesNotExist`.
+##
+## This uses [rust's std::path::is_dir](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_dir).
 ##
 ## > [`File.isDir`](File#isDir) does the same thing, except it takes a [Str] instead of a [Path].
 isDir : Path -> Task Bool [PathErr MetadataErr]
@@ -427,7 +430,9 @@ isDir = \path ->
     Task.ok (res == IsDir)
 
 ## Returns true if the path exists on disk and is pointing at a regular file.
-## Any error will return false.
+## Returns `Task.ok false` if the path exists and it is not a file. If the path does not exist,
+## this function will return `Task.err PathErr PathDoesNotExist`.
+##
 ## This uses [rust's std::path::is_file](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_file).
 ##
 ## > [`File.isFile`](File#isFile) does the same thing, except it takes a [Str] instead of a [Path].
@@ -437,7 +442,10 @@ isFile = \path ->
     Task.ok (res == IsFile)
 
 ## Returns true if the path exists on disk and is pointing at a symbolic link.
-## Any error will return false.
+## Returns `Task.ok false` if the path exists and it is not a symbolic link. If the path does not exist,
+## this function will return `Task.err PathErr PathDoesNotExist`.
+##
+## This uses [rust's std::path::is_symlink](https://doc.rust-lang.org/std/path/struct.Path.html#method.is_symlink).
 ##
 ## > [`File.isSymLink`](File#isSymLink) does the same thing, except it takes a [Str] instead of a [Path].
 isSymLink : Path -> Task Bool [PathErr MetadataErr]

platform/Stdin.roc

@@ -64,7 +64,7 @@ line =
     |> Task.mapErr handleErr
 
 ## Read bytes from [standard input](https://en.wikipedia.org/wiki/Standard_streams#Standard_input_(stdin)).
-## ‼️ This function can read no more than 256 bytes at a time. Use [readToEnd] if you need more.
+## ‼️ This function can read no more than 16,384 bytes at a time. Use [readToEnd] if you need more.
 ##
 ## > This is typically used in combintation with [Tty.enableRawMode],
 ## which disables defaults terminal bevahiour and allows reading input