Replaced PHPUnit attributes with annotations

Author: danielmorell

tests/Html/Input/BooleanInputTest.php

@@ -2,13 +2,9 @@
 
 namespace Rollbar\WordPress\Tests\Html\Input;
 
-use PHPUnit\Framework\Attributes\CoversClass;
-use Rollbar\WordPress\Html\Input\AbstractInput;
 use Rollbar\WordPress\Html\Input\BooleanInput;
 use Rollbar\WordPress\Tests\BaseTestCase;
 
-#[CoversClass(BooleanInput::class)]
-#[CoversClass(AbstractInput::class)]
 class BooleanInputTest extends BaseTestCase
 {
     private BooleanInput $subject;

tests/PluginTest.php

@@ -2,9 +2,6 @@
 
 namespace Rollbar\WordPress\Tests;
 
-use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\PreserveGlobalState;
-use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use Rollbar\Payload\Level;
 use Rollbar\Rollbar;
 use Rollbar\WordPress\Plugin;
@@ -56,26 +53,32 @@ public function testConfigure(): void
         self::assertEquals($expected, $output->getEnvironment());
     }
 
-    #[RunInSeparateProcess]
-    #[PreserveGlobalState(false)]
+    /**
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function testDisableAdmin(): void
     {
         self::assertFalse(Plugin::disabledAdmin());
         define('ROLLBAR_DISABLE_ADMIN', true);
         self::assertTrue(Plugin::disabledAdmin());
     }
 
-    #[RunInSeparateProcess]
-    #[PreserveGlobalState(false)]
+    /**
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function testDisableAdmin2(): void
     {
         self::assertFalse(Plugin::disabledAdmin());
         define('ROLLBAR_DISABLE_ADMIN', false);
         self::assertFalse(Plugin::disabledAdmin());
     }
 
-    #[RunInSeparateProcess]
-    #[PreserveGlobalState(false)]
+    /**
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function testHideAdmin(): void
     {
         add_action('rollbar_disable_admin', '__return_false');
@@ -89,7 +92,9 @@ public function testGetAssetUrl(): void
         self::assertStringEndsWith('/wp-content/plugins/rollbar/test.js', Plugin::getAssetUrl('test.js'));
     }
 
-    #[DataProvider('loggingLevelTestDataProvider')]
+    /**
+     * @dataProvider loggingLevelTestDataProvider
+     */
     public function testIncludedErrno(
         $loggingLevel,
         $errorLevel,

tests/SettingsTest.php

@@ -2,9 +2,6 @@
 
 namespace Rollbar\WordPress\Tests;
 
-use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\RunInSeparateProcess;
-use PHPUnit\Framework\Attributes\TestWith;
 use Rollbar\WordPress\Lib\AbstractSingleton;
 use Rollbar\WordPress\Settings;
 use Rollbar\WordPress\Settings\SettingType;
@@ -59,7 +56,9 @@ public function testGetDefaultSetting(): void
         self::assertTrue($settings->getDefaultOption('capture_error_stacktraces'));
     }
 
-    #[DataProvider('preUpdateProvider')]
+    /**
+     * @dataProvider preUpdateProvider
+     */
     public function testPreUpdate($expected, $data): void
     {
         self::assertEquals(
@@ -77,26 +76,31 @@ public function testSet(): void
         self::assertSame('bar', $settings->get('foo'));
     }
 
-    #[TestWith([true, true])]
-    #[TestWith([false, false])]
-    #[TestWith(['false', false])]
-    #[TestWith(['true', true])]
-    #[TestWith(['1', true])]
-    #[TestWith(['0', false])]
-    #[TestWith(['', false])]
-    #[TestWith(['yes', true])]
-    #[TestWith(['no', false])]
-    #[TestWith(['on', true])]
-    #[TestWith(['off', false])]
-    #[TestWith([0, false])]
-    #[TestWith([1, true])]
-    #[TestWith([-1, true])]
+    /**
+     * @testWith [true, true]
+     * @testWith [false, false]
+     * @testWith ['false', false]
+     * @testWith ['true', true]
+     * @testWith ['1', true]
+     * @testWith ['0', false]
+     * @testWith ['', false]
+     * @testWith ['yes', true]
+     * @testWith ['no', false]
+     * @testWith ['on', true]
+     * @testWith ['off', false]
+     * @testWith [0, false]
+     * @testWith [1, true]
+     * @testWith [-1, true]
+     */
     public function testToBoolean($value, $expected): void
     {
         self::assertSame($expected, Settings::toBoolean($value));
     }
 
-    #[RunInSeparateProcess]
+    /**
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function testRollbarSettingsConstant(): void
     {
         define('ROLLBAR_SETTINGS', [
@@ -110,7 +114,10 @@ public function testRollbarSettingsConstant(): void
         self::assertSame(['bar'], Settings::getInstance()->get('scrub_fields'));
     }
 
-    #[RunInSeparateProcess]
+    /**
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function testRollbarSettingsConstantPriority(): void
     {
         define('ROLLBAR_SETTINGS', [

tests/Telemetry/ListenerTest.php

@@ -2,7 +2,6 @@
 
 namespace Rollbar\WordPress\Tests\Telemetry;
 
-use PHPUnit\Framework\Attributes\TestWith;
 use Rollbar\Rollbar;
 use Rollbar\Telemetry\EventLevel;
 use Rollbar\Telemetry\EventType;
@@ -59,13 +58,9 @@ public function testInstrumentAction(): void
         self::assertTrue(has_action('delete_user'));
     }
 
-    #[TestWith(['delete_user', [true], 'delete_user: true'])]
-    #[TestWith(['register_post', [true, 1], 'register_post: true, 1'])]
-    #[TestWith(['wpmu_new_user', ['foo', 'bar'], 'wpmu_new_user: foo, bar'])]
-    #[TestWith(['check_admin_referer', [false], 'check_admin_referer: false'])]
-    #[TestWith(['admin_init', [[1, 2, 3, 'four']], 'admin_init: Array(4)'])]
-    #[TestWith(['wp_footer', [null], 'wp_footer: null'])]
-    #[TestWith(['edit_link', [5.84], 'edit_link: 5.84'])]
+    /**
+     * @dataProvider dataProviderConcatExtraArgs
+     */
     public function testConcatExtraArgs(string $action, array $args, string $expected): void
     {
         self::assertSame($expected, Listener::concatExtraArgs($action, ...$args));
@@ -93,4 +88,17 @@ public function testLog(): void
         self::assertSame('test', $last->body->message);
         self::assertSame(EventLevel::Critical, $last->level);
     }
+
+    public static function dataProviderConcatExtraArgs(): array
+    {
+        return [
+            ['delete_user', [true], 'delete_user: true'],
+            ['register_post', [true, 1], 'register_post: true, 1'],
+            ['wpmu_new_user', ['foo', 'bar'], 'wpmu_new_user: foo, bar'],
+            ['check_admin_referer', [false], 'check_admin_referer: false'],
+            ['admin_init', [[1, 2, 3, 'four']], 'admin_init: Array(4)'],
+            ['wp_footer', [null], 'wp_footer: null'],
+            ['edit_link', [5.84], 'edit_link: 5.84'],
+        ];
+    }
 }