Skip to content

Commit 27e6528

Browse files
committed
[ci] Keep one build with check_connection=ON
Since `check_connection=ON` is the default from ROOT builds from source, it is important to test this in the CI. But we don't want to test this in general, because of the constant risk that the probe file on `root.cern` can't be downloaded. So we should test it on a platform that uses builtins that trigger the connection check, and where sporadic build failues annoy us the least. The platforms that use lots of builtins and will therefore trigger the connection check forever are `windows` and `macos`. We don't have many Windows CI configs, so we should not risk one of them. Therefore, I suggest to use some `mac` platform. I would not use `mac-beta`, because we should definitely not be blind to cutting-edge macOS development. Some older - more stable - macOS release would be better. But we also don't want to have to update the CI config too often, so I think `mac15` is a good choice, because we still have several years before this platform will be dropped.
1 parent ce557c0 commit 27e6528

File tree

1 file changed

+1
-0
lines changed
  • .github/workflows/root-ci-config/buildconfig

1 file changed

+1
-0
lines changed

.github/workflows/root-ci-config/buildconfig/mac15.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ builtin_xrootd=ON
2323
builtin_xxhash=ON
2424
builtin_zeromq=ON
2525
builtin_zstd=ON
26+
check_connection=ON
2627
cocoa=ON
2728
minuit2_omp=OFF
2829
tmva-sofie=ON

0 commit comments

Comments
 (0)