Skip to content

Conversation

@noamross
Copy link
Contributor

@noamross noamross commented Sep 8, 2025

Also move text on non-responding authors to this section.

Resolves #846

@noamross noamross requested a review from maelle September 8, 2025 20:40
maelle
maelle previously requested changes Sep 9, 2025
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@noamross noamross marked this pull request as ready for review September 9, 2025 22:49
@noamross noamross requested review from a team as code owners September 9, 2025 22:49
@noamross noamross requested review from beatrizmilz and yabellini and removed request for a team September 9, 2025 22:49

#### Desafios durante a revisão {#challenges-during-review}

- **Se o autor parar de responder** consulte [as políticas](#policies) e/ou envie um ping para os outros editores no canal do Slack para discussão. É importante ressaltar que, se um revisor foi atribuído a um problema fechado, entre em contato com ele ao fechar o problema para explicar a decisão e agradecê-lo mais uma vez pelo trabalho. Informe os outros editores no canal Slack para que eles sejam considerados para um pacote no futuro com grandes chances de uma revisão de software tranquila (por exemplo, um autor de pacote que já tenha enviado pacotes para nós).
Copy link
Contributor

@beatrizmilz beatrizmilz Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Just to clarify If I understood correcly:

"Let the other editors know in the Slack channel to consider them for a package in the future with high chances of smooth software review (e.g. a package author who has already submitted packages to us)."

I think I'm not sure if I understood the context of the whole sentence. In this case, "consider them" is related to the reviewer, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right.

@yabellini
Copy link
Member

I will review it next week; it needs more work than usual because of the gender mark. Plus, it replaces text that we already translated and reviewed (like the first paragraph), so I need to be careful to put that back and only translate the new lines.

@beatrizmilz
Copy link
Contributor

I still have to review the gender marks, but I will try to do it this week.

Next week I'll be at Posit Conf 🎉 From what I have seen, @noamross and I will be at the same session. Looking forward to meeting you there!

Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing wording to respect original translation and remove gender mark from new content.

Co-authored-by: Yanina Bellini Saibene <[email protected]>
Co-authored-by: Beatriz Milz <[email protected]>
@maelle
Copy link
Member

maelle commented Sep 23, 2025

Thanks so much @beatrizmilz @yabellini (and thanks again @noamross!)

@maelle maelle dismissed their stale review September 23, 2025 10:17

The changes we made. I am maelle.

@maelle maelle merged commit 46c7b71 into main Sep 23, 2025
1 check passed
@mpadge mpadge deleted the review-challenges branch September 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide guidance on dealing with late or non-responding reviewers

5 participants