Cleanup: used assertion methods

Author: rameel

Main/src/Threading/AsyncOperationHelper.cs

@@ -31,8 +31,8 @@ public static class AsyncOperationHelper
 		/// </param>
 		public static void Post([NotNull] this AsyncOperation asyncOp, [NotNull, InstantHandle] Action runner)
 		{
-			if (asyncOp == null) throw new ArgumentNullException(nameof(asyncOp));
-			if (runner == null) throw new ArgumentNullException(nameof(runner));
+			Code.NotNull(asyncOp, nameof(asyncOp));
+			Code.NotNull(runner, nameof(runner));
 			asyncOp.Post(state => runner(), null);
 		}
 
@@ -41,12 +41,10 @@ public static void Post([NotNull] this AsyncOperation asyncOp, [NotNull, Instant
 		/// </summary>
 		/// <param name="asyncOp"></param>
 		/// <param name="runner">A <see cref="Action"/> that wraps the delegate to be called when the operation ends.</param>
-		public static void PostOperationCompleted(
-			[NotNull] this AsyncOperation asyncOp,
-			[NotNull, InstantHandle] Action runner)
+		public static void PostOperationCompleted([NotNull] this AsyncOperation asyncOp, [NotNull, InstantHandle] Action runner)
 		{
-			if (asyncOp == null) throw new ArgumentNullException(nameof(asyncOp));
-			if (runner == null) throw new ArgumentNullException(nameof(runner));
+			Code.NotNull(asyncOp, nameof(asyncOp));
+			Code.NotNull(runner, nameof(runner));
 			asyncOp.PostOperationCompleted(state => runner(), null);
 		}
 
@@ -58,7 +56,7 @@ public static void PostOperationCompleted(
 		/// <param name="runner">
 		/// A <see cref="Action"/> that wraps the delegate to be called when the operation ends.
 		/// </param>
-		public static void Send([NotNull] this AsyncOperation asyncOp, [NotNull] Action runner)
+		public static void Send([NotNull] this AsyncOperation asyncOp, [NotNull, InstantHandle] Action runner)
 		{
 			if (asyncOp == null) throw new ArgumentNullException(nameof(asyncOp));
 			if (runner == null) throw new ArgumentNullException(nameof(runner));
@@ -75,10 +73,11 @@ public static void Send([NotNull] this AsyncOperation asyncOp, [NotNull] Action
 		/// A <see cref="Func{TResult}"/> that wraps the delegate to be called when the operation ends.
 		/// </param>
 		/// <returns>Result of <paramref name="runner"/> execution.</returns>
-		public static T Send<T>([NotNull] this AsyncOperation asyncOp, [NotNull] Func<T> runner)
+		public static T Send<T>([NotNull] this AsyncOperation asyncOp, [NotNull, InstantHandle] Func<T> runner)
 		{
-			if (asyncOp == null) throw new ArgumentNullException(nameof(asyncOp));
-			if (runner == null) throw new ArgumentNullException(nameof(runner));
+			Code.NotNull(asyncOp, nameof(asyncOp));
+			Code.NotNull(runner, nameof(runner));
+
 			var result = default(T);
 			asyncOp.SynchronizationContext.Send(state => result = runner(), null);
 			return result;
@@ -87,11 +86,10 @@ public static T Send<T>([NotNull] this AsyncOperation asyncOp, [NotNull] Func<T>
 		/// <summary>
 		/// Gets thread from pool and run <paramref name="runner"/> inside it.
 		/// </summary>
-		/// <param name="runner">Action to run inside created thread</param>
-		public static void RunAsync([NotNull] Action<AsyncOperation> runner)
+		/// <param name="runner">Action to run inside created thread.</param>
+		public static void RunAsync([NotNull, InstantHandle] Action<AsyncOperation> runner)
 		{
-			if (runner == null)
-				throw new ArgumentNullException(nameof(runner));
+			Code.NotNull(runner, nameof(runner));
 
 			var asyncOp = CreateOperation();
 			ThreadPool.QueueUserWorkItem(state => runner(asyncOp));
@@ -100,18 +98,16 @@ public static void RunAsync([NotNull] Action<AsyncOperation> runner)
 		/// <summary>
 		/// Gets thread from pool and run <paramref name="runner"/> inside it.
 		/// </summary>
-		/// <param name="runner">Action to run inside created thread</param>
+		/// <param name="runner">Action to run inside created thread.</param>
 		/// <param name="completeHandler">
 		/// Action called after <paramref name="runner"/> complete execution. Synchronized with method calling thread.
 		/// </param>
 		public static void RunAsync(
-			Action<AsyncOperation> runner,
-			Action completeHandler)
+			[NotNull, InstantHandle] Action<AsyncOperation> runner,
+			[NotNull, InstantHandle] Action completeHandler)
 		{
-			if (runner == null)
-				throw new ArgumentNullException(nameof(runner));
-			if (completeHandler == null)
-				throw new ArgumentNullException(nameof(completeHandler));
+			Code.NotNull(runner, nameof(runner));
+			Code.NotNull(completeHandler, nameof(completeHandler));
 
 			var asyncOp = CreateOperation();
 			ThreadPool.QueueUserWorkItem(

Main/src/Threading/ConcurrentLazyDictionary.cs

@@ -27,9 +27,10 @@ public class ConcurrentLazyDictionary<TKey, TValue> : ILazyDictionary<TKey, TVal
 		/// </summary>
 		/// <param name="valueFactory">Function to create value on demand.</param>
 		/// <param name="comparer">Key comparer.</param>
-		public ConcurrentLazyDictionary([NotNull] Func<TKey, TValue> valueFactory, IEqualityComparer<TKey> comparer)
+		public ConcurrentLazyDictionary([NotNull] Func<TKey, TValue> valueFactory, [NotNull] IEqualityComparer<TKey> comparer)
 		{
-			if (valueFactory == null) throw new ArgumentNullException(nameof(valueFactory));
+			Code.NotNull(valueFactory, nameof(valueFactory));
+
 			_valueFactory = valueFactory;
 			_comparer = comparer;
 			_map = new ConcurrentDictionary<TKey, TValue>(comparer);

Main/src/Threading/ExecSyncConcurrentLazyDictionary.cs

@@ -29,9 +29,12 @@ public class ExecSyncConcurrentLazyDictionary<TKey, TValue> : ILazyDictionary<TK
 		/// </summary>
 		/// <param name="valueFactory">Function to create value on demand.</param>
 		/// <param name="comparer">Key comparer.</param>
-		public ExecSyncConcurrentLazyDictionary([NotNull] Func<TKey, TValue> valueFactory, IEqualityComparer<TKey> comparer)
+		public ExecSyncConcurrentLazyDictionary(
+			[NotNull] Func<TKey, TValue> valueFactory,
+			[NotNull] IEqualityComparer<TKey> comparer)
 		{
-			if (valueFactory == null) throw new ArgumentNullException(nameof(valueFactory));
+			Code.NotNull(valueFactory, nameof(valueFactory));
+
 			_valueFactory = valueFactory;
 			_comparer = comparer;
 			_map = new ConcurrentDictionary<TKey, Lazy<TValue>>(comparer);

Main/src/Threading/ParallelExtensions.cs

@@ -30,9 +30,9 @@ public static void RunInParallel<TSource,TTarget>(
 			[NotNull, InstantHandle] Action<TTarget> consumerAction,
 			string processName = "ParallelProcess")
 		{
-			if (source         == null) throw new ArgumentNullException(nameof(source));
-			if (providerFunc   == null) throw new ArgumentNullException(nameof(providerFunc));
-			if (consumerAction == null) throw new ArgumentNullException(nameof(consumerAction));
+			Code.NotNull(source, nameof(source));
+			Code.NotNull(providerFunc, nameof(providerFunc));
+			Code.NotNull(consumerAction, nameof(consumerAction));
 
 			using (var providerQueue = new ParallelQueue(providerCount, processName + "_provider_"))
 			using (var consumerQueue = new ParallelQueue(consumerCount, processName + "_consumer_"))