コメントなど微修正

Author: YusukeKato

.test/lint.sh

@@ -10,6 +10,7 @@ lint_driver () {
         python3 $SRC_DIR/.test/bin/run-clang-format.py rtmouse_dev.c
         python3 $SRC_DIR/.test/bin/run-clang-format.py rtmouse_spi.c
         python3 $SRC_DIR/.test/bin/run-clang-format.py rtmouse_i2c.c
+        python3 $SRC_DIR/.test/bin/run-clang-format.py rtmouse_gpio.c
         python3 $SRC_DIR/.test/bin/run-clang-format.py rtmouse.h
     popd
 }

src/drivers/rtmouse.h

@@ -52,7 +52,7 @@
 // Raspberry Pi 2 B        : 2
 // Raspberry Pi 3 B/A+/B+  : 2
 // Raspberry Pi 4 B        : 4
-#define RASPBERRYPI 4
+#define RASPBERRYPI 2
 
 /* --- Device ID --- */
 #define ID_DEV_LED 0
@@ -252,9 +252,8 @@ struct rtcnt_device_info {
 	int raw_pulse_count;
 };
 
-/* --- used in rtmouse_dev_fops.c --- */
+/* --- used in rtmouse_dev.c --- */
 extern const char *NAME_DEV[ID_DEV_SIZE];
-extern const char *NAME_DEV_U[ID_DEV_SIZE];
 extern int _major_dev[ID_DEV_SIZE];
 extern int _minor_dev[ID_DEV_SIZE];
 extern struct class *class_dev[ID_DEV_SIZE];

src/drivers/rtmouse_dev.c

@@ -25,6 +25,19 @@
 static unsigned int motor_l_freq_is_positive = 1;
 static unsigned int motor_r_freq_is_positive = 1;
 
+/*
+ * --- Device Names(+%u) ---
+ * used in register_dev()
+ */
+static const char *NAME_DEV_U[ID_DEV_SIZE] = {[ID_DEV_LED] = "rtled%u",
+				       [ID_DEV_SWITCH] = "rtswitch%u",
+				       [ID_DEV_SENSOR] = "rtlightsensor%u",
+				       [ID_DEV_BUZZER] = "rtbuzzer%u",
+				       [ID_DEV_MOTORRAWR] = "rtmotor_raw_r%u",
+				       [ID_DEV_MOTORRAWL] = "rtmotor_raw_l%u",
+				       [ID_DEV_MOTOREN] = "rtmotoren%u",
+				       [ID_DEV_MOTOR] = "rtmotor%u"};
+
 /*
  * i2c_counter_set - set value to I2C pulse counter
  * called by rtcnt_write()

src/drivers/rtmouse_main.c

@@ -31,7 +31,8 @@ MODULE_DESCRIPTION("Raspberry Pi Mouse device driver");
 
 /*
  * --- Device Numbers ---
- * used in rtmouse_i2c.c
+ * used in rtmouse_i2c.c, dev_init_module()
+ * and cleanup_each_dev()
  */
 const unsigned int NUM_DEV[ID_DEV_SIZE] = {
     [ID_DEV_LED] = 4,	  [ID_DEV_SWITCH] = 3,	  [ID_DEV_SENSOR] = 1,
@@ -40,7 +41,7 @@ const unsigned int NUM_DEV[ID_DEV_SIZE] = {
 
 /*
  * --- Device Names ---
- * used in rtmouse_dev.c
+ * used in rtmouse_dev.c and dev_init_module()
  */
 const char *NAME_DEV[ID_DEV_SIZE] = {[ID_DEV_LED] = "rtled",
 				     [ID_DEV_SWITCH] = "rtswitch",
@@ -51,19 +52,6 @@ const char *NAME_DEV[ID_DEV_SIZE] = {[ID_DEV_LED] = "rtled",
 				     [ID_DEV_MOTOREN] = "rtmotoren",
 				     [ID_DEV_MOTOR] = "rtmotor"};
 
-/*
- * --- Device Names(+%u) ---
- * used in rtmouse_dev.c
- */
-const char *NAME_DEV_U[ID_DEV_SIZE] = {[ID_DEV_LED] = "rtled%u",
-				       [ID_DEV_SWITCH] = "rtswitch%u",
-				       [ID_DEV_SENSOR] = "rtlightsensor%u",
-				       [ID_DEV_BUZZER] = "rtbuzzer%u",
-				       [ID_DEV_MOTORRAWR] = "rtmotor_raw_r%u",
-				       [ID_DEV_MOTORRAWL] = "rtmotor_raw_l%u",
-				       [ID_DEV_MOTOREN] = "rtmotoren%u",
-				       [ID_DEV_MOTOR] = "rtmotor%u"};
-
 // used in by rtmouse_dev.c and cleanup_each_dev()
 int _major_dev[ID_DEV_SIZE] = {
     [ID_DEV_LED] = DEV_MAJOR,	    [ID_DEV_SWITCH] = DEV_MAJOR,
@@ -80,21 +68,25 @@ int _minor_dev[ID_DEV_SIZE] = {
 
 /*
  * --- General Options ---
- * used in rtmouse_dev.c
+ * used in rtmouse_dev.c and dev_cleanup_module()
  */
 struct class *class_dev[ID_DEV_SIZE] = {
     [ID_DEV_LED] = NULL,       [ID_DEV_SWITCH] = NULL,
     [ID_DEV_SENSOR] = NULL,    [ID_DEV_BUZZER] = NULL,
     [ID_DEV_MOTORRAWR] = NULL, [ID_DEV_MOTORRAWL] = NULL,
     [ID_DEV_MOTOREN] = NULL,   [ID_DEV_MOTOR] = NULL};
 
-// used in rtmouse_i2c.c
+// used in rtmouse_i2c.c and dev_cleanup_module()
 struct cdev *cdev_array = NULL;
+
+// used in rtmouse_i2c.c
 volatile int cdev_index = 0;
 
-// used in rtmouse_dev.c
+// used in rtmouse_dev.c and rtmouse_gpio.c
 volatile void __iomem *pwm_base;
 volatile uint32_t *gpio_base;
+
+// used in rtmouse_dev.c, rtmouse_i2c.c and rtmouse_spi.c
 struct mutex lock;
 
 /* --- Static variables --- */