-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
I tried writing some code using the netlink-packet-sock-diag
crate, using docs.rs to understand the Nla
enum. According to those docs, the TcpInfo
variant contains a Vec<u8>
, which I took to mean that decoding isn't available for this data structure.
I was surprised when I looked at the source code and discovered that decoding was present but required a feature flag. Perhaps the docs for this enum should contain a note that decoding requires a feature flag to be enabled?
I also notice that enabling the feature flag makes incompatible changes to the enum contents, making code no longer compile. This is a non-additive feature; it would be better to follow Cargo's guidance and ensure that enabling features doesn't break the existing public API.
Metadata
Metadata
Assignees
Labels
No labels