- Fix for delete of decimalSeparator happening when fixeDecimalScale is set. #789

Author: s-yadav

src/numeric_format.tsx

@@ -426,14 +426,13 @@ export function useNumericFormat<BaseType = InputAttributes>(
     }
 
     // don't allow user to delete decimal separator when decimalScale and fixedDecimalScale is set
-    if (
-      key === 'Backspace' &&
-      value[selectionStart - 1] === decimalSeparator &&
-      decimalScale &&
-      fixedDecimalScale
-    ) {
-      setCaretPosition(el, selectionStart - 1);
-      e.preventDefault();
+    if (decimalScale && fixedDecimalScale) {
+      if (key === 'Backspace' && value[selectionStart - 1] === decimalSeparator) {
+        setCaretPosition(el, selectionStart - 1);
+        e.preventDefault();
+      } else if (key === 'Delete' && value[selectionStart] === decimalSeparator) {
+        e.preventDefault();
+      }
     }
 
     // if user presses the allowed decimal separator before the separator, move the cursor after the separator

test/library/input_numeric_format.spec.js

@@ -731,6 +731,16 @@ describe('Test NumberFormat as input with numeric format options', () => {
     expect(input.value).toEqual('2,00');
   });
 
+  it('should not delete decimal separator if delete key is pressed before decimal separator when fixedDecimalScale is provided. #789', async () => {
+    const { input } = await render(
+      <NumericFormat value={'123.000'} decimalScale={3} fixedDecimalScale />,
+    );
+
+    simulateNativeKeyInput(input, '{delete}', 3, 3);
+
+    expect(input.value).toEqual('123.000');
+  });
+
   describe('should allow typing number if prefix or suffix is just an number #691', () => {
     it('when prefix is number', async () => {
       const { input } = await render(<NumericFormat prefix="1" />);