Skip to content

Commit 5e80ca6

Browse files
authored
Minor fixes before version release (#41)
* Fixed missing REQUIRED notes * revert incorrect filename numbering * remove irrelevant MarkHidden error messages * typo fix
1 parent 5ce986d commit 5e80ca6

File tree

5 files changed

+18
-9
lines changed

5 files changed

+18
-9
lines changed

src/cmd/add.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var addCmd = &cobra.Command{
3333
func init() {
3434
rootCmd.AddCommand(addCmd)
3535

36-
addCmd.PersistentFlags().StringVarP(&addCmdArgs.endpoint, "endpoint", "e", addCmdArgs.endpoint, "socket address of wireguard listener; client address if inbound handshake and server address if outbound (example \"1.2.3.4:51820\")")
36+
addCmd.PersistentFlags().StringVarP(&addCmdArgs.endpoint, "endpoint", "e", addCmdArgs.endpoint, "[REQUIRED] socket address of wireguard listener; client address if inbound handshake and server address if outbound (example \"1.2.3.4:51820\")")
3737
addCmd.PersistentFlags().BoolVar(&addCmdArgs.outbound, "outbound", addCmdArgs.outbound, "use endpoint to initiate handshake out to server instead of the other way around")
3838
addCmd.PersistentFlags().IntVarP(&addCmdArgs.port, "port", "p", addCmdArgs.port, "port of wireguard listener; client port if inbound handshake and server port if outbound")
3939

@@ -48,7 +48,9 @@ func init() {
4848
helpFunc := addCmd.HelpFunc()
4949
addCmd.SetHelpFunc(func(cmd *cobra.Command, args []string) {
5050
if !ShowHidden {
51-
for _, f := range []string{"keepalive"} {
51+
for _, f := range []string{
52+
"keepalive",
53+
} {
5254
err := cmd.Flags().MarkHidden(f)
5355
if err != nil {
5456
fmt.Printf("Failed to hide flag %v: %v\n", f, err)

src/cmd/add_client.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,11 @@ func init() {
6969
} {
7070
err := cmd.Flags().MarkHidden(f)
7171
if err != nil {
72-
fmt.Printf("Failed to hide flag %v: %v\n", f, err)
72+
if strings.HasSuffix(err.Error(), "does not exist") {
73+
//add_server also runs this and complains about args it doesn't recognize
74+
} else {
75+
fmt.Printf("Failed to hide flag %v: %v\n", f, err)
76+
}
7377
}
7478
}
7579
}

src/cmd/add_server.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var addServerCmd = &cobra.Command{
4848
func init() {
4949
addCmd.AddCommand(addServerCmd)
5050

51-
addServerCmd.Flags().StringSliceVarP(&addServerCmdArgs.allowedIPs, "routes", "r", addServerCmdArgs.allowedIPs, "CIDR IP ranges that will be routed through wiretap")
51+
addServerCmd.Flags().StringSliceVarP(&addServerCmdArgs.allowedIPs, "routes", "r", addServerCmdArgs.allowedIPs, "[REQUIRED] CIDR IP ranges that will be routed through wiretap")
5252
addServerCmd.Flags().StringVarP(&addServerCmdArgs.serverAddress, "server-address", "s", addServerCmdArgs.serverAddress, "API address of server that new server will connect to, connects to client by default")
5353
addServerCmd.Flags().StringVarP(&addServerCmdArgs.configFileRelay, "relay-input", "", addServerCmdArgs.configFileRelay, "filename of input relay config file")
5454
addServerCmd.Flags().StringVarP(&addServerCmdArgs.configFileE2EE, "e2ee-input", "", addServerCmdArgs.configFileE2EE, "filename of input E2EE config file")
@@ -65,15 +65,18 @@ func init() {
6565
addCmd.SetHelpFunc(func(cmd *cobra.Command, args []string) {
6666
if !ShowHidden {
6767
for _, f := range []string{
68-
"relay-output",
69-
"e2ee-output",
7068
"relay-input",
7169
"e2ee-input",
7270
"server-output",
7371
} {
7472
err := cmd.Flags().MarkHidden(f)
7573
if err != nil {
76-
fmt.Printf("Failed to hide flag %v: %v\n", f, err)
74+
if strings.HasSuffix(err.Error(), "does not exist") {
75+
//add_client also runs this and complains about args it doesn't recognize
76+
} else {
77+
fmt.Printf("Failed to hide flag %v: %v\n", f, err)
78+
}
79+
7780
}
7881
}
7982
}

src/cmd/expose.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func init() {
5353
cmd.Flags().StringVarP(&exposeCmd.protocol, "protocol", "p", exposeCmd.protocol, "Port protocol, tcp/udp")
5454
cmd.Flags().BoolVarP(&exposeCmd.dynamic, "dynamic", "d", exposeCmd.dynamic, "Dynamic port forwarding, SOCKS proxy service opens on remote port")
5555
cmd.PersistentFlags().StringVarP(&exposeCmd.serverAddr, "server-address", "s", exposeCmd.serverAddr, "API address of server that ports should be forwarded from, exposes service to all servers by default")
56-
cmd.PersistentFlags().StringVarP(&exposeCmd.configFile, "config", "c", exposeCmd.configFile, "Config file needed when talking to all serves (the default)")
56+
cmd.PersistentFlags().StringVarP(&exposeCmd.configFile, "config", "c", exposeCmd.configFile, "Config file needed when talking to all servers (the default)")
5757

5858
cmd.MarkFlagsMutuallyExclusive("dynamic", "local")
5959

src/peer/peer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func GetNextPrefixesForPeers(peers []PeerConfig) []netip.Prefix {
8383

8484
// Add number to filename if it already exists.
8585
func FindAvailableFilename(f string) string {
86-
count := 2
86+
count := 1
8787
ext := filepath.Ext(f)
8888
basename := strings.TrimSuffix(f, ext)
8989
for {

0 commit comments

Comments
 (0)