Skip to content

Removed DiktatRunnerFactory #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Removed DiktatRunnerFactory #1835

wants to merge 6 commits into from

Conversation

@nulls
Copy link
Member

@nulls nulls commented Nov 30, 2023

What's done:

  • removed DiktatRunnerFactory
  • refactored DiktatRunner to object (singleton)

@nulls nulls self-assigned this Nov 30, 2023
@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

2 files   -    162  2 suites   - 162   11s ⏱️ - 7m 59s
5 tests  - 1 397  5 ✔️  - 1 361  0 💤  - 36  0 ❌ ±0 
5 runs   - 2 776  5 ✔️  - 2 740  0 💤  - 36  0 ❌ ±0 

Results for commit c75ff9d. ± Comparison against base commit 3ebe006.

This pull request removes 1397 tests. 
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in githubActions mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with excludes()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with non-existent inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check system property with custom config()
…

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 files   -    162  2 suites   - 162   11s ⏱️ - 6m 59s
5 tests  - 1 397  5 ✔️  - 1 380  0 💤  - 17  0 ❌ ±0 
5 runs   - 2 776  5 ✔️  - 2 759  0 💤  - 17  0 ❌ ±0 

Results for commit c75ff9d. ± Comparison against base commit 3ebe006.

This pull request removes 1397 tests. 
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in githubActions mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with excludes()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with non-existent inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check system property with custom config()
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nulls nulls

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nulls