Skip to content

Commit 4996e6c

Browse files
committed
Improve CoreTests a bit
1 parent ac94f3d commit 4996e6c

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

Tests/CoreTests.swift

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,8 @@ class CoreTests: XCTestCase {
206206
func floatingPanel(_ fpc: FloatingPanelController, layoutFor newCollection: UITraitCollection) -> FloatingPanelLayout { layout }
207207
func floatingPanel(_ fpc: FloatingPanelController, layoutFor size: CGSize) -> FloatingPanelLayout { layout }
208208
}
209-
func round(_ alpha: CGFloat) -> CGFloat {
210-
return (fpc.backdropView.alpha * 1e+06).rounded() / 1e+06
211-
}
212209

210+
let acc = 0.000_001
213211
let timeout = 5.0
214212

215213
let delegate = TestDelegate()
@@ -219,27 +217,27 @@ class CoreTests: XCTestCase {
219217
fpc.showForTest()
220218

221219
fpc.move(to: .full, animated: false)
222-
XCTAssertEqual(round(fpc.backdropView.alpha), 0.3)
220+
XCTAssertEqual(fpc.backdropView.alpha, 0.3, accuracy: acc)
223221

224222
fpc.move(to: .half, animated: false)
225-
XCTAssertEqual(fpc.backdropView.alpha, 0.0)
223+
XCTAssertEqual(fpc.backdropView.alpha, 0.0, accuracy: acc)
226224

227225
fpc.move(to: .tip, animated: false)
228-
XCTAssertEqual(round(fpc.backdropView.alpha), 0.3)
226+
XCTAssertEqual(fpc.backdropView.alpha, 0.3, accuracy: acc)
229227

230228
let exp1 = expectation(description: "move to full with animation")
231229
fpc.move(to: .full, animated: true) {
232230
exp1.fulfill()
233231
}
234232
wait(for: [exp1], timeout: timeout)
235-
XCTAssertEqual(round(fpc.backdropView.alpha), 0.3)
233+
XCTAssertEqual(fpc.backdropView.alpha, 0.3, accuracy: acc)
236234

237235
let exp2 = expectation(description: "move to half with animation")
238236
fpc.move(to: .half, animated: true) {
239237
exp2.fulfill()
240238
}
241239
wait(for: [exp2], timeout: timeout)
242-
XCTAssertEqual(fpc.backdropView.alpha, 0.0)
240+
XCTAssertEqual(fpc.backdropView.alpha, 0.0, accuracy: acc)
243241

244242
// Test a content mode change of FloatingPanelController
245243

@@ -250,12 +248,12 @@ class CoreTests: XCTestCase {
250248
fpc.contentMode = .fitToBounds
251249
XCTAssertEqual(fpc.backdropView.alpha, 0.0) // Must not affect the backdrop alpha by changing the content mode
252250
wait(for: [exp3], timeout: timeout)
253-
XCTAssertEqual(round(fpc.backdropView.alpha), 0.3)
251+
XCTAssertEqual(fpc.backdropView.alpha, 0.3, accuracy: acc)
254252

255253
// Test a size class change of FloatingPanelController.view
256254

257255
fpc.move(to: .full, animated: false)
258-
XCTAssertEqual(round(fpc.backdropView.alpha), 0.3)
256+
XCTAssertEqual(fpc.backdropView.alpha, 0.3, accuracy: acc)
259257
fpc.willTransition(to: UITraitCollection(horizontalSizeClass: .regular), with: MockTransitionCoordinator())
260258
XCTAssertEqual(fpc.backdropView.alpha, 0.0) // Must update the alpha by BackdropTestLayout2 in TestDelegate.
261259

@@ -264,7 +262,7 @@ class CoreTests: XCTestCase {
264262
fpc.move(to: .full, animated: false)
265263
delegate.layout = BackdropTestLayout()
266264
fpc.invalidateLayout()
267-
XCTAssertEqual(round(fpc.backdropView.alpha), 0.3)
265+
XCTAssertEqual(fpc.backdropView.alpha, 0.3, accuracy: acc)
268266

269267
delegate.layout = BackdropTestLayout2()
270268
fpc.viewWillTransition(to: CGSize.zero, with: MockTransitionCoordinator())

0 commit comments

Comments
 (0)