fix(nemesis): avoid masking KillNemesis in nemesis #11889
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fruch , could you please take a look? Also Im not sure of how to test it, maybe you have some suggestions? |
timtimb0t
force-pushed
the
kill_nemesis_exception
branch
from
c7ffcc0 to
22d62de
Compare
A short run of only this specific nemesis, to validate first it doesn't break/regress it, other then that I don't see more that should be tested. |
timtimb0t
force-pushed
the
kill_nemesis_exception
branch
from
22d62de to
27d9b35
Compare
this is minor change that allow to avoid masking KillNemesis in _refuse_connection_from_banned_node fix: scylladb#11816
timtimb0t
force-pushed
the
kill_nemesis_exception
branch
from
27d9b35 to
b9e6d24
Compare
vponomaryov
added
backport/2025.3
and removed
backport/none
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is minor change that allow to avoid masking KillNemesis
in _refuse_connection_from_banned_node
fix: #11816
Testing:
https://jenkins.scylladb.com/job/scylla-staging/job/eugene_test_folder/job/longevity-twcs-48h-test/2/
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)