Avoid Mono's ParameterInfo[].AsSpan() bug (#1571)

CreepGin · web-flow · commit b1df4cb43763 · 2023-07-02T09:05:10.000+03:00
diff --git a/Jint/Runtime/Interop/TypeReference.cs b/Jint/Runtime/Interop/TypeReference.cs
@@ -134,9 +134,10 @@ static ObjectInstance ObjectCreator(Engine engine, Realm realm, ObjectCreateStat
                         if (parameters.Length > arguments.Length)
                         {
                             // all missing ones must be optional
-                            foreach (var parameter in parameters.AsSpan(parameters.Length - arguments.Length))
+                            int start = parameters.Length - arguments.Length;
+                            for (var i = start; i < parameters.Length; i++)
                             {
-                                if (!parameter.IsOptional)
+                                if (!parameters[i].IsOptional)
                                 {
                                     // use original arguments
                                     return arguments;

Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,10 @@ static ObjectInstance ObjectCreator(Engine engine, Realm realm, ObjectCreateStat`
`134`	`134`	`if (parameters.Length > arguments.Length)`
`135`	`135`	`{`
`136`	`136`	`// all missing ones must be optional`
`137`		`- foreach (var parameter in parameters.AsSpan(parameters.Length - arguments.Length))`
	`137`	`+ int start = parameters.Length - arguments.Length;`
	`138`	`+ for (var i = start; i < parameters.Length; i++)`
`138`	`139`	`{`
`139`		`- if (!parameter.IsOptional)`
	`140`	`+ if (!parameters[i].IsOptional)`
`140`	`141`	`{`
`141`	`142`	`// use original arguments`
`142`	`143`	`return arguments;`