From 93b346cac1f6102c555fd3964b1b60526d2e151e Mon Sep 17 00:00:00 2001
From: w41ter <w41ter.l@gmail.com>
Date: Tue, 30 Sep 2025 11:25:41 +0800
Subject: [PATCH] Fix adding variant column with properties

---
 pkg/ccr/base/spec.go      |  8 ++++++
 pkg/ccr/base/spec_test.go | 60 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)

diff --git a/pkg/ccr/base/spec.go b/pkg/ccr/base/spec.go
index d0b42a72..ad981c07 100644
--- a/pkg/ccr/base/spec.go
+++ b/pkg/ccr/base/spec.go
@@ -1708,6 +1708,14 @@ func HandleSchemaChangeDefaultValue(sql string, lightningSchemaChange *record.Mo
 	return sql
 }
 
+func HandleSchemaChangeVariantProperties(sql string, lightningSchemaChange *record.ModifyTableAddOrDropColumns) string {
+	re := regexp.MustCompile(`variant<.*PROPERTIES\s*\(.*,\)>|VARIANT<.*PROPERTIES\s*\(.*,\)>`)
+	replaceFn := func(match string) string {
+		return strings.ReplaceAll(match, ",)>", ")>")
+	}
+	return re.ReplaceAllStringFunc(sql, replaceFn)
+}
+
 func NormalizeCreateViewSql(destDatabase string, srcDatabase string, createSql string) string {
 	log.Tracef("create view, use dest db name to replace source db name")
 	originSql := createSql
diff --git a/pkg/ccr/base/spec_test.go b/pkg/ccr/base/spec_test.go
index eeaf1f08..74cb6f2c 100644
--- a/pkg/ccr/base/spec_test.go
+++ b/pkg/ccr/base/spec_test.go
@@ -17,6 +17,7 @@
 package base_test
 
 import (
+	"fmt"
 	"reflect"
 	"testing"
 
@@ -225,3 +226,62 @@ func TestNormalizeCreateTableSql(t *testing.T) {
 		}
 	}
 }
+
+func TestHandleSchemaChangeVariantProperties(t *testing.T) {
+	data := `{
+	"dbId":1759183589184,
+	"tableId":1759183589229,
+	"baseIndexId":1759183589230,
+	"indexSchemaMap": {
+		"1759183589230":[{
+			"name":"id",
+			"type":{"clazz":"ScalarType","type":"INT","len":-1,"precision":0,"scale":0},
+			"isAggregationTypeImplicit":false,
+			"isKey":true,"isAllowNull":true,
+			"isAutoInc":false,
+			"autoIncInitValue":-1,
+			"comment":"",
+			"stats":{"avgSerializedSize":-1.0,"maxSize":-1,"numDistinctValues":-1,"numNulls":-1},
+			"children":[],"visible":true,"uniqueId":0,"clusterKeyId":-1,"hasOnUpdateDefaultValue":false,"gctt":[]
+		}, {
+			"name":"j","type":{"clazz":"ScalarType","type":"JSONB","len":-1,"precision":0,"scale":0},
+			"aggregationType":"NONE","isAggregationTypeImplicit":true,"isKey":false,"isAllowNull":true,
+			"isAutoInc":false,"autoIncInitValue":0,"comment":"",
+			"stats":{"avgSerializedSize":-1.0,"maxSize":-1,"numDistinctValues":-1,"numNulls":-1},
+			"children":[],"visible":true,"uniqueId":1,"clusterKeyId":-1,"hasOnUpdateDefaultValue":false,"gctt":[]
+		},{
+			"name":"v",
+			"type":{"clazz":"VariantType","fieldMap":{},"fields":[],"variantMaxSubcolumnsCount":2,"enableTypedPathsToSparse":false,
+				"variantMaxSparseColumnStatisticsSize":10000,"type":"VARIANT","len":-1,"precision":0,"scale":0},
+			"aggregationType":"NONE","isAggregationTypeImplicit":true,"isKey":false,"isAllowNull":true,"isAutoInc":false,"autoIncInitValue":0,
+			"comment":"",
+			"stats":{"avgSerializedSize":-1.0,"maxSize":-1,"numDistinctValues":-1,"numNulls":-1},
+			"children":[],"visible":true,"uniqueId":2,"clusterKeyId":-1,"hasOnUpdateDefaultValue":false,"gctt":[]
+		}]},
+		"oldIndexSchemaMap":{
+			"1759183589230":[
+				{"name":"id","type":{"clazz":"ScalarType","type":"INT","len":-1,"precision":0,"scale":0},
+					"isAggregationTypeImplicit":false,"isKey":true,"isAllowNull":true,"isAutoInc":false,"autoIncInitValue":-1,"comment":"",
+					"stats":{"avgSerializedSize":-1.0,"maxSize":-1,"numDistinctValues":-1,"numNulls":-1},
+					"children":[],"visible":true,"uniqueId":0,"clusterKeyId":-1,"hasOnUpdateDefaultValue":false,"gctt":[]},
+				{"name":"j","type":{"clazz":"ScalarType","type":"JSONB","len":-1,"precision":0,"scale":0},
+					"aggregationType":"NONE","isAggregationTypeImplicit":true,"isKey":false,"isAllowNull":true,"isAutoInc":false,
+					"autoIncInitValue":0,"comment":"","stats":{"avgSerializedSize":-1.0,"maxSize":-1,"numDistinctValues":-1,"numNulls":-1},
+					"children":[],"visible":true,"uniqueId":1,"clusterKeyId":-1,"hasOnUpdateDefaultValue":false,"gctt":[]}
+				]},"indexNameToId":{"tbl_332464610":1759183589230},
+				"indexes":[],"jobId":1759183590091,
+				"rawSql":"%s"}`
+
+	raw := "ALTER TABLE `regression_test_db_sync_cdt_column_add`.`tbl_332464610` ADD COLUMN `v` variant\\u003cPROPERTIES (\\\"variant_max_subcolumns_count\\\" \\u003d \\\"2\\\",)\u003e NULL COMMENT \\\"\\\""
+	expect := "ALTER TABLE `regression_test_db_sync_cdt_column_add`.`tbl_332464610` ADD COLUMN `v` variant<PROPERTIES (\"variant_max_subcolumns_count\" = \"2\")> NULL COMMENT \"\""
+
+	data = fmt.Sprintf(data, raw)
+	origin, err := record.NewModifyTableAddOrDropColumnsFromJson(data)
+	if err != nil {
+		t.Errorf("unmarshal json failed, err: %v", err)
+		return
+	}
+	if actual := base.HandleSchemaChangeVariantProperties(origin.RawSql, origin); actual != expect {
+		t.Errorf("case failed, expect %s, but got %s", expect, actual)
+	}
+}