[Lint] Add `python/sglang` to ruff F401 checks and remove unused imports in files #11685

CatherineSue · 2025-10-15T22:13:26Z

Motivation

This PR adds F401 to ruff checks and removes unused imports accross python/sglang, excluding __init__.py.

Modifications

Added F821 to ruff checks - this catches undefined names/missing imports
Added python/sglang to ruff checks, excluded all init.py
Tried to fix all unused imports

Accuracy Tests

Benchmarking and Profiling

Checklist

Format your code according to the Format code with pre-commit.
Add unit tests according to the Run and add unit tests.
Update documentation according to Write documentations.
Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.

gemini-code-assist · 2025-10-15T22:15:05Z

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the project's code quality and maintainability by refining the linting process. It integrates more comprehensive ruff checks for unused imports and undefined names across the core python/sglang codebase. This initiative has led to a substantial cleanup, removing redundant import statements and clarifying code dependencies, which ultimately results in a leaner, more robust, and easier-to-understand codebase.

Highlights

Ruff Configuration Update: The .pre-commit-config.yaml has been updated to include F821 (undefined names) alongside F401 (unused imports) in the ruff checks. This enhances the static analysis capabilities for Python code.
Expanded Linting Scope: The ruff linter's scope has been extended to cover the entire python/sglang directory. A new exclusion rule has been added to ignore __init__.py files from these checks, preventing unnecessary warnings in package initialization files.
Extensive Unused Import Removal: Numerous Python files across the python/sglang directory have been cleaned by removing unused import statements. This includes both direct removals and the addition of # noqa: F401 comments for imports that are intentionally present but not directly referenced in the code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

CatherineSue · 2025-10-15T22:16:23Z

python/sglang/srt/compilation/cuda_piecewise_backend.py

 import torch
 import torch.fx as fx

-import sglang.srt.compilation.weak_ref_tensor_jit


Not sure about this one.

CatherineSue · 2025-10-15T22:16:51Z

python/sglang/srt/layers/attention/npu_ops/mla_preprocess.py



 if is_mla_preprocess_enabled():
-    import sgl_kernel_npu


Not sure about this one.

we need to keep this

Added back in 17b44c5

gemini-code-assist

Code Review

This pull request is a great step towards improving code quality by enabling more ruff checks (F401 for unused imports and F821 for undefined names) across the python/sglang directory and cleaning up existing unused imports. The changes are extensive but mostly automated, which is good.

I've made a few suggestions to improve the clarity and maintainability of how noqa comments are used to suppress F401 warnings. Specifically, I've pointed out cases where blanket noqa comments on multi-line imports can be ambiguous and where single-line imports would be more readable.

Overall, this is a valuable cleanup effort. Thank you for this contribution!

python/sglang/srt/layers/activation.py

python/sglang/srt/layers/attention/nsa_backend.py

python/sglang/srt/layers/moe/moe_runner/triton.py

python/sglang/srt/layers/attention/nsa/nsa_indexer.py

- F821: missing imports - Exclude all __init__.py

# Conflicts: # python/sglang/srt/disaggregation/decode.py # python/sglang/srt/disaggregation/prefill.py # python/sglang/srt/model_executor/npu_graph_runner.py

- Comes from merge conflicts

CatherineSue · 2025-10-16T20:17:31Z

Will take alook at the CI failures

CatherineSue · 2025-10-16T22:44:19Z

Execute Notebooks is due to github connection issue.

unit-test-backend-8-gpu (1): test_disaggregation_hybrid_attention.py failed due to KV Transfer failure in disaggregation mode. It seems from mooncake. Not related to changes in disaggregation/prefill.py or decode.py.

unit-test-deepep-8-gpu: test_deepep_large.py failed due to InfiniBand GPU device mapping failure: GPU cannot map UAR of device mlx5_roce7 , not sure if it is relevant.

Started a CI rerun.

CatherineSue · 2025-10-16T22:45:03Z

Keep seeing RuntimeError: There is no current event loop in thread 'MainThread'. Cancelled workflow for now

ping1jing2 · 2025-10-17T04:26:23Z

Keep seeing RuntimeError: There is no current event loop in thread 'MainThread'. Cancelled workflow for now

NPU CI has some network issue, we are handle it, you can ignore it first. If this PR break NPU code, we will fix it by ourself.

CatherineSue · 2025-10-17T23:24:19Z

All NV tests passed: https://github.com/sgl-project/sglang/actions/runs/18605205543?pr=11685

…rts in files (sgl-project#11685)

sglang-bot added the run-ci label Oct 15, 2025

CatherineSue commented Oct 15, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 15, 2025

View reviewed changes

python/sglang/srt/layers/activation.py Show resolved Hide resolved

python/sglang/srt/layers/attention/nsa_backend.py Show resolved Hide resolved

python/sglang/srt/layers/moe/moe_runner/triton.py Show resolved Hide resolved

zhyncs approved these changes Oct 15, 2025

View reviewed changes

slin1237 approved these changes Oct 15, 2025

View reviewed changes

ping1jing2 reviewed Oct 16, 2025

View reviewed changes

python/sglang/srt/layers/attention/nsa/nsa_indexer.py Show resolved Hide resolved

Add F821 and python/sglang/ in .pre-commit-config.yaml

ccf7308

- F821: missing imports - Exclude all __init__.py

CatherineSue added 5 commits October 16, 2025 09:00

Remove all missing imports

f234947

# Conflicts: # python/sglang/srt/disaggregation/decode.py # python/sglang/srt/disaggregation/prefill.py # python/sglang/srt/model_executor/npu_graph_runner.py

Add # noqa: F401 to add files that check imports

1512391

Add back imports in deep_gemm_wrapper/entrypoints.py with noqa

3c8f9c8

Add import custom_ops back nsa_indexer.py

9b06d38

Remove unused imports in prefill.py, decode.py, and npu_graph_runner.py

1f0fa29

- Comes from merge conflicts

CatherineSue force-pushed the chang/unused-imports branch from 63d21ce to 1f0fa29 Compare October 16, 2025 16:06

Add back import sgl_kernel_npu in mla_preprocess.py

17b44c5

zhyncs self-assigned this Oct 16, 2025

Merge branch 'main' into chang/unused-imports

0dfe6b8

CatherineSue added 2 commits October 16, 2025 15:48

Remove unused imports in qwen3_vl.py and qwen3_vl_moe.py

ad12515

Merge branch 'main' into chang/unused-imports

1193243

CatherineSue and others added 2 commits October 17, 2025 14:17

Merge branch 'main' into chang/unused-imports

ac05574

fix

4e57942

zhyncs approved these changes Oct 17, 2025

View reviewed changes

zhyncs merged commit 6279744 into main Oct 17, 2025
100 of 108 checks passed

zhyncs deleted the chang/unused-imports branch October 17, 2025 23:49

hnyls2002 mentioned this pull request Oct 21, 2025

[lint] improve ruff check #11922

Merged

leavelet pushed a commit to pkucnc/sglang that referenced this pull request Oct 27, 2025

[Lint] Add python/sglang to ruff F401 checks and remove unused impo…

1ec6b44

…rts in files (sgl-project#11685)

[Lint] Add python/sglang to ruff F401 checks and remove unused imports in files #11685

[Lint] Add python/sglang to ruff F401 checks and remove unused imports in files #11685

Uh oh!

Conversation

CatherineSue commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Uh oh!

gemini-code-assist bot commented Oct 15, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

CatherineSue Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

CatherineSue Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

zhyncs Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

CatherineSue Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CatherineSue commented Oct 16, 2025

Uh oh!

CatherineSue commented Oct 16, 2025

Uh oh!

CatherineSue commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ping1jing2 commented Oct 17, 2025

Uh oh!

CatherineSue commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[Lint] Add `python/sglang` to ruff F401 checks and remove unused imports in files #11685

[Lint] Add `python/sglang` to ruff F401 checks and remove unused imports in files #11685

CatherineSue commented Oct 15, 2025 •

edited

Loading

CatherineSue commented Oct 16, 2025 •

edited

Loading

CatherineSue commented Oct 17, 2025 •

edited

Loading