Skip to content

Commit 1bf4733

Browse files
author
billy clark
committed
Merge remote-tracking branch 'origin/develop'
2 parents 85b6834 + 27ed2f1 commit 1bf4733

File tree

9 files changed

+152
-297
lines changed

9 files changed

+152
-297
lines changed

docker/deployment/app-deployment.yaml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,23 @@ spec:
6565
labels:
6666
app: app
6767
spec:
68+
affinity:
69+
# required to ensure this container makes it to lfmerge's dedicated node
70+
nodeAffinity:
71+
preferredDuringSchedulingIgnoredDuringExecution:
72+
- preference:
73+
matchExpressions:
74+
- key: dedicated
75+
operator: In
76+
values:
77+
- lfmerge
78+
weight: 1
79+
# required to ensure this container makes it to lfmerge's dedicated node
80+
tolerations:
81+
- effect: NoSchedule
82+
key: dedicated
83+
operator: Equal
84+
value: lfmerge
6885
volumes:
6986
- name: assets
7087
persistentVolumeClaim:

docker/deployment/lfmerge-deployment.yaml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,17 @@ spec:
6666
app: lfmerge
6767
spec:
6868
affinity:
69+
# required to ensure this container makes it to a dedicated node (so it doesn't crash other containers when it blows up)
70+
nodeAffinity:
71+
preferredDuringSchedulingIgnoredDuringExecution:
72+
- preference:
73+
matchExpressions:
74+
- key: dedicated
75+
operator: In
76+
values:
77+
- lfmerge
78+
weight: 1
79+
# need to keep this on the same pod as the app since inotify only gets notification when updates occur on the same kernel
6980
podAffinity:
7081
requiredDuringSchedulingIgnoredDuringExecution:
7182
- labelSelector:
@@ -75,6 +86,12 @@ spec:
7586
values:
7687
- app
7788
topologyKey: kubernetes.io/hostname
89+
# required to ensure this container makes it to a dedicated node (so it doesn't crash other containers when it blows up)
90+
tolerations:
91+
- effect: NoSchedule
92+
key: dedicated
93+
operator: Equal
94+
value: lfmerge
7895
volumes:
7996
- name: sendreceive-data
8097
persistentVolumeClaim:

docs/RELEASE.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,24 @@ Language Forge is built to run in a containerized environment. Kubernetes is ou
1515

1616
[qa.languageforge.org](https://qa.languageforge.org)
1717

18-
Staging deployments can be manually run with `VERSION_APP=<some-docker-tag-or-semver> VERSION_PROXY=<some-docker-tag-or-semver> VERSION_NEXT_APP=<some-docker-tag-or-semver> VERSION_LFMERGE=<some-docker-tag-or-semver> make deploy-staging`.
19-
2018
Current workflow:
2119
1. merge PR into or make commits on `develop` branch
2220
1. this will kick off the GHA (`.github/workflows/staging.yml`) to build, test and publish the necessary images to Docker Hub (https://hub.docker.com/r/sillsdev/web-languageforge/tags) and deploy this code to the staging environment at https://qa.languageforge.org
2321

22+
Staging deployments can be manually run with `VERSION_APP=<some-docker-tag-or-semver> VERSION_PROXY=<some-docker-tag-or-semver> VERSION_NEXT_APP=<some-docker-tag-or-semver> VERSION_LFMERGE=<some-docker-tag-or-semver> make deploy-staging`.
23+
2424
### Production ###
2525

2626
[languageforge.org](https://languageforge.org)
2727

28-
Production deployments can be manually run with `VERSION_APP=<some-docker-tag-or-semver> VERSION_PROXY=<some-docker-tag-or-semver> VERSION_NEXT_APP=<some-docker-tag-or-semver> VERSION_LFMERGE=<some-docker-tag-or-semver> make deploy-prod`.
29-
3028
Current workflow:
3129
1. merge from `develop` into `master`
3230
1. "Draft a new release" on https://github.com/sillsdev/web-languageforge/releases with a `vYYYY-MM-DD` tag format
3331
1. "Publish" the new release
3432
1. this will kick off the GHA (`.github/workflows/production.yml`) to build, test and publish the necessary images to Docker Hub (https://hub.docker.com/r/sillsdev/web-languageforge/tags) and deploy this code to the production environment at https://languageforge.org
3533

34+
Production deployments can be manually run with `VERSION_APP=<some-docker-tag-or-semver> VERSION_PROXY=<some-docker-tag-or-semver> VERSION_NEXT_APP=<some-docker-tag-or-semver> VERSION_LFMERGE=<some-docker-tag-or-semver> make deploy-prod`.
35+
3636
### Revert ###
3737
Various tagged images are maintained in Docker Hub. If you need to revert to a previous version, you can do so by running the deployments scripts with the appropriate permissions or utilizing the Kubernetes UI to change the image of a deployment at any time.
3838

package-lock.json

Lines changed: 110 additions & 62 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Api/Model/Languageforge/Lexicon/Command/LexEntryCommands.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ public static function updateEntry($projectId, $params, $userId, $mergeQueuePath
149149
ActivityCommands::writeEntry($project, $userId, $entry, $action, $differences);
150150

151151
// SendReceiveCommands::queueProjectForUpdate($project, $mergeQueuePath);
152-
// SendReceiveCommands::startLFMergeIfRequired($projectId, 'merge', $pidFilePath, $command);
153152

154153
return JsonEncoder::encode($entry);
155154
}

0 commit comments

Comments
 (0)