Skip to content

Commit 6d2333a

Browse files
committed
Update notifications related docs
1 parent 7f9d643 commit 6d2333a

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

UPGRADING.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ List of changes since the *CONFIG_VERSION* numbering was introduced:
8484
* Added *NOTIFICATIONS_* options to *deployment/settings.py*::
8585

8686
# Notifications configuration (client)
87-
# This one is for JavaScript socket.io client.
87+
# This one is for JavaScript WebSocket client.
8888
# It should contain actual URL available from remote machines.
8989
NOTIFICATIONS_SERVER_URL = 'http://localhost:7887/'
9090

oioioi/default_settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@
780780
RANKING_MAX_COOLDOWN = 100 # seconds
781781

782782
# Notifications configuration (client)
783-
# This one is for JavaScript socket.io client.
783+
# This one is for JavaScript WebSocket client.
784784
# It should contain actual URL available from remote machines.
785785
NOTIFICATIONS_SERVER_URL = 'http://localhost:7887/'
786786

oioioi/deployment/settings.py.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ ZEUS_INSTANCES = {
501501
# RANKING_MAX_COOLDOWN = 100 # seconds
502502

503503
# Notifications configuration (client)
504-
# This one is for JavaScript socket.io client.
504+
# This one is for JavaScript WebSocket client.
505505
# It should contain actual URL available from remote machines.
506506
# NOTIFICATIONS_SERVER_URL = 'http://localhost:7887/'
507507

oioioi/notifications/README.rst

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
An optional module for transmitting instant notifications to users.
2-
It consists of a Django app and a Node.js server passing notifications.
2+
It consists of a Django app and a Python server passing notifications.
3+
The server is tested with normal Django unit tests.
34

45
How to use:
56
- expose port 7887 for web container in docker-compose-dev.yml
67
- open container bash (easy_toolbox.py bash)
7-
- install Node.js (sudo apt install nodejs npm)
88
- uncomment notifications from INSTALLED_APPS in settings.py
99
- uncomment notifications from context_processors in settings.py
1010
- set following settings in settings.py:
@@ -23,8 +23,6 @@ If required, modify appropriate settings in settings.py file - their names begin
2323
with "NOTIFICATIONS_" prefix.
2424

2525

26-
How to run tests:
27-
- in ./server directory, invoke: npm test
2826

2927
How to notify users manually:
3028
- invoke: ./manage.py notify [options]

oioioi/szkopul/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@
425425
}
426426

427427
# Notifications configuration (client)
428-
# This one is for JavaScript socket.io client.
428+
# This one is for JavaScript WebSocket client.
429429
# It should contain actual URL available from remote machines.
430430
# NOTIFICATIONS_SERVER_URL = '//szkopul-notifications.dasie.mimuw.edu.pl/'
431431
NOTIFICATIONS_SERVER_URL = '/'

0 commit comments

Comments
 (0)