Skip to content

Commit dcbf59b

Browse files
committed
Merge pull request #19 from skipperbent/development
Development
2 parents 969b646 + bc16388 commit dcbf59b

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

src/Pecee/SimpleRouter/RouterBase.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ public function routeRequest() {
116116
$routeNotAllowed = false;
117117

118118
$this->loadedRoute = $routeMatch;
119+
$routeMatch->loadMiddleware($this->request);
119120
$routeMatch->renderRoute($this->request);
120121
break;
121122
}

src/Pecee/SimpleRouter/RouterEntry.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,9 @@ public function match($regex) {
179179
public function getMergeableSettings() {
180180
$settings = $this->settings;
181181

182-
if(isset($settings['middleware'])) {
182+
/*if(isset($settings['middleware'])) {
183183
unset($settings['middleware']);
184-
}
184+
}*/
185185

186186
if(isset($settings['prefix'])) {
187187
unset($settings['prefix']);
@@ -243,7 +243,7 @@ protected function loadClass($name) {
243243
return new $name();
244244
}
245245

246-
protected function loadMiddleware(Request $request) {
246+
public function loadMiddleware(Request $request) {
247247
if($this->getMiddleware()) {
248248
$middleware = $this->loadClass($this->getMiddleware());
249249
if (!($middleware instanceof Middleware)) {
@@ -256,8 +256,6 @@ protected function loadMiddleware(Request $request) {
256256
}
257257

258258
public function renderRoute(Request $request) {
259-
// Load middleware
260-
$this->loadMiddleware($request);
261259

262260
if(is_object($this->getCallback()) && is_callable($this->getCallback())) {
263261

src/Pecee/SimpleRouter/RouterGroup.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public function __construct() {
1010
parent::__construct();
1111
}
1212

13-
public function matchRoute(Request $request) {
13+
public function renderRoute(Request $request) {
1414
// Check if request method is allowed
1515

1616
if(strtolower($request->getUri()) == strtolower($this->prefix) || stripos($request->getUri(), $this->prefix) === 0) {
@@ -29,11 +29,17 @@ public function matchRoute(Request $request) {
2929
throw new RouterException('Method not allowed');
3030
}
3131

32-
return $this;
32+
$this->loadMiddleware($request);
33+
34+
return parent::renderRoute($request);
3335
}
3436

3537
// No match here, move on...
3638
return null;
3739
}
3840

41+
public function matchRoute(Request $request) {
42+
return null;
43+
}
44+
3945
}

src/Pecee/SimpleRouter/RouterResource.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ public function __construct($url, $controller) {
2020
}
2121

2222
public function renderRoute(Request $request) {
23-
// Load middleware
24-
$this->loadMiddleware($request);
25-
2623
if(is_object($this->getCallback()) && is_callable($this->getCallback())) {
2724
// When the callback is a function
2825
call_user_func_array($this->getCallback(), $this->getParameters());

0 commit comments

Comments
 (0)