Skip to content

Commit a5cc0c3

Browse files
chore: Remove old TODO (#4152)
# Summary Remove old TODO Fixes #1780 ## Testing Process n/a ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [x] Update documentation if applicable. - [x] Add unit tests if applicable. - [x] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. Signed-off-by: Ian Lewis <[email protected]> Co-authored-by: Ramon Petgrave <[email protected]>
1 parent 9255e11 commit a5cc0c3

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

.github/actions/verify-token/dist/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,8 @@ function run() {
158158
(0, validate_1.validateGitHubFields)(rawTokenObj.github);
159159
// Validate the build Action is not empty.
160160
(0, validate_1.validateFieldNonEmpty)("tool.actions.build_artifacts.path", rawTokenObj.tool.actions.build_artifacts.path);
161-
// No validation needed for the builder inputs,
161+
// NOTE: No validation needed for the builder inputs,
162162
// they may be empty.
163-
// TODO(#1780): test empty inputs.
164163
// Extract certificate information.
165164
const [toolURI, toolRepository, toolRef, toolSha, toolPath] = (0, utils_1.parseCertificate)(bundle);
166165
// Extract the inputs.

.github/actions/verify-token/dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/actions/verify-token/src/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,8 @@ async function run(): Promise<void> {
141141
rawTokenObj.tool.actions.build_artifacts.path,
142142
);
143143

144-
// No validation needed for the builder inputs,
144+
// NOTE: No validation needed for the builder inputs,
145145
// they may be empty.
146-
// TODO(#1780): test empty inputs.
147146

148147
// Extract certificate information.
149148
const [toolURI, toolRepository, toolRef, toolSha, toolPath] =

0 commit comments

Comments
 (0)