Cosmetic generator fixes

Author: mullermp

gems/smithy/lib/smithy/templates/client/endpoint_provider_spec.erb

@@ -27,8 +27,8 @@ module <%= module_name %>
         expect(endpoint.properties).to eq(expected['endpoint']['properties'] || {})
 <% end -%>
       end
-
 <% test_case.operation_inputs.each do |operation_input| -%>
+
       it 'produces the correct output from the client when calling <%= operation_input.operation_name %>' do
         client = Client.new(
           stub_responses: true,

gems/smithy/lib/smithy/templates/client/waiters.erb

@@ -3,9 +3,9 @@
 # This is generated code!
 
 module <%= module_name %>
-
   # @api private
   module Waiters
+
 <% waiters.each do |waiter| -%>
 <% if waiter.deprecated? -%>
     # @deprecated

gems/smithy/lib/smithy/views/client/auth_resolver.rb

@@ -35,7 +35,7 @@ def auth_rules_code
 
         def add_service_auth_schemes_to_code(lines)
           service_auth_schemes.each do |auth_scheme|
-            lines << "options << Smithy::Client::AuthOption.new(scheme_id: '#{auth_scheme}')"
+            lines << "  options << Smithy::Client::AuthOption.new(scheme_id: '#{auth_scheme}')"
           end
         end
 

gems/smithy/lib/smithy/views/client/endpoint_parameter.rb

@@ -55,7 +55,7 @@ def default_value
         end
 
         def validate_required?
-          @data['required'] && !@data['default']
+          @data['required'] && !@data.key?('default')
         end
 
         def create_from_config?

gems/smithy/lib/smithy/views/client/endpoint_parameters.rb

@@ -11,8 +11,7 @@ def initialize(plan)
           service = @plan.service
           @endpoint_rules = service.values.first['traits']['smithy.rules#endpointRuleSet']
           @operations = Model::ServiceIndex.new(@model).operations_for(@plan.service)
-          @parameters = @endpoint_rules['parameters']
-                        .map { |id, data| EndpointParameter.new(id, data, @plan) }
+          @parameters = @endpoint_rules['parameters'].map { |id, data| EndpointParameter.new(id, data, @plan) }
           @operation_params = build_operation_params
 
           super()

gems/smithy/lib/smithy/views/client/schema.rb

@@ -168,8 +168,9 @@ def initialize(service, id, shape)
           attr_reader :type, :id, :name
 
           def initializer
-            traits_str = ", traits: #{@traits}" unless @traits.empty?
-            "::Smithy::Schema::Shapes::#{SHAPE_CLASS_MAP[@type]}.new(id: '#{@id}', name: '#{@name}'#{traits_str})"
+            options_str = "id: \"#{@id}\", name: \"#{@name}\""
+            options_str += ", traits: #{@traits}" unless @traits.empty?
+            "::Smithy::Schema::Shapes::#{SHAPE_CLASS_MAP[@type]}.new(#{options_str})"
           end
         end
 
@@ -327,7 +328,7 @@ def initialize(service, location_name, shape_ref)
 
           def initializer
             options_str = "shape: #{@shape}"
-            options_str += ", location_name: '#{@location_name}'" if @location_name
+            options_str += ", location_name: \"#{@location_name}\"" if @location_name
             options_str += ", traits: #{@traits}" unless @traits.empty?
             "::Smithy::Schema::Shapes::ShapeRef.new(#{options_str})"
           end